-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide names of local variables via FramePointerAnalysis #10906
Conversation
With a25b6c7 we are at 1126 cases where we still load
further progress: |
88ecb93
to
0195953
Compare
After fixes made so far I can:
and then:
we are able to start Enso with |
engine/runtime/src/main/scala/org/enso/interpreter/runtime/IrToTruffle.scala
Show resolved
Hide resolved
engine/runtime-compiler/src/main/scala/org/enso/compiler/context/LocalScope.scala
Outdated
Show resolved
Hide resolved
val result = symbols() | ||
System.err.println( | ||
"BAD!!!! Computing from scope at " + where + " = " + result | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's replace this with Logger
and use it in a test to detect no BAD!!!
situations happen (when running test/Base_Tests
, etc.). Btw. they do happen when using EvalNode
and I believe that's necessary as it evaluates random code and needs the LocalScope
with AliasGraph
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in c87f67a - use:
./enso --log-level trace --run xyz.enso | grep "] Scope"
to see messages about "Scope computed from AliasAnalysis".
...ne/runtime-compiler/src/main/scala/org/enso/compiler/pass/analyse/FramePointerAnalysis.scala
Outdated
Show resolved
Hide resolved
...ne/runtime-compiler/src/main/scala/org/enso/compiler/pass/analyse/FramePointerAnalysis.scala
Outdated
Show resolved
Hide resolved
...ne/runtime-compiler/src/main/scala/org/enso/compiler/pass/analyse/FramePointerAnalysis.scala
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/scala/org/enso/interpreter/runtime/IrToTruffle.scala
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/scope/TopLevelScope.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see at least some improvement. Although we all have expected a bigger improvement, because of the size of AliasAnalysis, but at least something. Some nits.
engine/runtime-compiler/src/main/scala/org/enso/compiler/pass/analyse/alias/graph/Graph.scala
Outdated
Show resolved
Hide resolved
engine/runtime-compiler/src/main/scala/org/enso/compiler/context/LocalScope.scala
Show resolved
Hide resolved
engine/runtime-compiler/src/main/scala/org/enso/compiler/context/LocalScope.scala
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/scope/TopLevelScope.java
Show resolved
Hide resolved
engine/runtime/src/main/scala/org/enso/interpreter/runtime/IrToTruffle.scala
Show resolved
Hide resolved
...ne/runtime-compiler/src/main/scala/org/enso/compiler/pass/analyse/FramePointerAnalysis.scala
Outdated
Show resolved
Hide resolved
engine/runtime-integration-tests/src/test/java/org/enso/compiler/ExecCompilerTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly nits
...ne/runtime-compiler/src/main/scala/org/enso/compiler/pass/analyse/FramePointerAnalysis.scala
Outdated
Show resolved
Hide resolved
...ne/runtime-compiler/src/main/scala/org/enso/compiler/pass/analyse/FramePointerAnalysis.scala
Outdated
Show resolved
Hide resolved
...ne/runtime-compiler/src/main/scala/org/enso/compiler/pass/analyse/FramePointerAnalysis.scala
Outdated
Show resolved
Hide resolved
...ne/runtime-compiler/src/main/scala/org/enso/compiler/pass/analyse/FramePointerAnalysis.scala
Outdated
Show resolved
Hide resolved
engine/runtime-compiler/src/main/scala/org/enso/compiler/pass/analyse/alias/graph/Graph.scala
Show resolved
Hide resolved
engine/runtime/src/main/scala/org/enso/interpreter/runtime/IrToTruffle.scala
Show resolved
Hide resolved
engine/runtime-compiler/src/main/java/org/enso/compiler/pass/analyse/FrameAnalysisMeta.java
Show resolved
Hide resolved
engine/runtime-compiler/src/main/scala/org/enso/compiler/context/LocalScope.scala
Show resolved
Hide resolved
engine/runtime-compiler/src/main/scala/org/enso/compiler/pass/analyse/alias/graph/Graph.scala
Show resolved
Hide resolved
engine/runtime/src/main/scala/org/enso/interpreter/runtime/IrToTruffle.scala
Show resolved
Hide resolved
Co-authored-by: Hubert Plociniczak <[email protected]>
Co-authored-by: Hubert Plociniczak <[email protected]>
Co-authored-by: Hubert Plociniczak <[email protected]>
(cherry picked from commit d37b8f3)
Pull Request Description
Fixes #10843 by enhancing the
FramePointerAnalysis
pass to computevariableNames
forIR
nodes that haveAliasAnalysis.RootScope
orAliasAnalysis.ChildScope
.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,