Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding return type to signature causes Don't use interop for EnsoObject error #10613

Closed
GregoryTravis opened this issue Jul 19, 2024 · 2 comments · Fixed by #10650
Closed

Adding return type to signature causes Don't use interop for EnsoObject error #10613

GregoryTravis opened this issue Jul 19, 2024 · 2 comments · Fixed by #10650
Assignees
Labels
-compiler p-low Low priority

Comments

@GregoryTravis
Copy link
Contributor

GregoryTravis commented Jul 19, 2024

Adding -> Integer to the checked return type of Decimal.to_integer results in the error below (when running Decimal_Spec).

If the Warning.attach is removed, the problem goes away, so I imagine that the error we want to get here is something about Any is not Integer.

(I also tried keeping Warning.attach but casting it to Integer, and also got the error below in that case.)

Change on https://github.com/enso-org/enso/tree/bug/gmt/10613.

    - [PENDING] should compare correctly to Integer and Float
        Reason: https://github.com/enso-org/enso/issues/10163
Execution finished with an error: java.lang.AssertionError: Don't use interop for EnsoObject: org.enso.interpreter.runtime.error.WithWarnings
        at <java> org.enso.runtime/org.enso.interpreter.runtime.library.dispatch.TypeOfNode$WithoutType$Interop.resolve(TypeOfNode.java:213)
        at <java> org.enso.runtime/org.enso.interpreter.runtime.library.dispatch.TypeOfNode.withoutType(TypeOfNode.java:83)
        at <java> org.enso.runtime/org.enso.interpreter.runtime.library.dispatch.TypeOfNodeGen.execute(TypeOfNodeGen.java:186)
        at <java> org.enso.runtime/org.enso.interpreter.node.expression.builtin.meta.IsValueOfTypeNode.typeAndCheck(IsValueOfTypeNode.java:55)
        at <java> org.enso.runtime/org.enso.interpreter.node.expression.builtin.meta.IsValueOfTypeNode$Untyped.doOther(IsValueOfTypeNode.java:180)
@JaroslavTulach JaroslavTulach self-assigned this Jul 23, 2024
@JaroslavTulach JaroslavTulach moved this from ❓New to 👁️ Code review in Issues Board Jul 24, 2024
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Jul 24, 2024
@enso-bot
Copy link

enso-bot bot commented Jul 25, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-07-24):

Progress: - Fix #10613 by #10650

@enso-bot
Copy link

enso-bot bot commented Jul 26, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-07-25):

Progress: - TreeToIr continued: #10645 (comment)

GitHub
Closes #8682 Pull Request Description

Important Notes

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

The documentation has been updated, if ne...

GitHub
Closes #8682 Pull Request Description

Important Notes

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

The documentation has been updated, if ne...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-compiler p-low Low priority
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants