Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid race condition in GC_Example test #10665

Merged
merged 8 commits into from
Jul 29, 2024
Merged

Avoid race condition in GC_Example test #10665

merged 8 commits into from
Jul 29, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jul 25, 2024

Pull Request Description

Re-enables https://github.com/enso-org/enso/pull/10602/files#r1690919173 - uses IO.println to allow us to see what the CI actually does.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
  • Unit tests are being analyzed

@JaroslavTulach JaroslavTulach self-assigned this Jul 25, 2024
@JaroslavTulach JaroslavTulach marked this pull request as draft July 25, 2024 07:04
@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 25, 2024
@JaroslavTulach JaroslavTulach linked an issue Jul 25, 2024 that may be closed by this pull request
@JaroslavTulach
Copy link
Member Author

First run:

OK, let's try to schedule another run.

@JaroslavTulach
Copy link
Member Author

Another successful run:

What's next?

@JaroslavTulach JaroslavTulach marked this pull request as ready for review July 25, 2024 10:17
@JaroslavTulach JaroslavTulach requested a review from 4e6 as a code owner July 25, 2024 10:17
@JaroslavTulach
Copy link
Member Author

We might hit the GC problem with Native Image tests:

DEBUG main_internal:Running process for the output.{command=Command:
	ENSO_DATA_DIRECTORY="/Users/runner/work/enso/enso/built-distribution/enso-engine-2024.3.1-dev-macos-amd64/enso-2024.3.1-dev" "/Users/runner/work/enso/enso/built-distribution/enso-engine-2024.3.1-dev-macos-amd64/enso-2024.3.1-dev/bin/enso" "--run" "/Users/runner/work/enso/enso/test/Base_Tests"
	with environment overrides:
		ENSO_DATA_DIRECTORY=/Users/runner/work/enso/enso/built-distribution/enso-engine-2024.3.1-dev-macos-amd64/enso-2024.3.1-dev}: ide_ci::program::command: Spawning.

I guess I should enable log output, at least.

@JaroslavTulach JaroslavTulach requested a review from Frizi as a code owner July 25, 2024 15:27
@JaroslavTulach
Copy link
Member Author

All checks have passed including the native image run on Linux with output.

@JaroslavTulach
Copy link
Member Author

And we have a test failure on Linux:

 INFO ide_ci::program::command: enso ℹ️ Still 10418 resources to clean up...
 INFO ide_ci::program::command: enso ℹ️ Still 10418 resources to clean up...
 INFO ide_ci::program::command: enso ℹ️ Still 10418 resources to clean up...
 INFO ide_ci::program::command: enso ℹ️ Still 10418 resources to clean up...

I am inclined to believe the test is wrong...

@JaroslavTulach JaroslavTulach changed the title Investigating what's wrong with GC_Example test Avoid race conditions in GC_Example test Jul 26, 2024
@JaroslavTulach
Copy link
Member Author

Previous runs blocked by

let's hope we merge by end of this week

@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Jul 26, 2024
@JaroslavTulach JaroslavTulach changed the title Avoid race conditions in GC_Example test Avoid race condition in GC_Example test Jul 26, 2024
@enso-bot
Copy link

enso-bot bot commented Jul 27, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-07-26):

Progress: - fixed the test to allocate first and only then GC: #10665 (comment)

Discord
Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.

build/build/src/engine/context.rs Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 07bc728 into develop Jul 29, 2024
75 checks passed
@mergify mergify bot deleted the wip/jtulach/Gc10211 branch July 29, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jobs appear to be stuck on Base_Tests
5 participants