ContextFactory reused to initialize language-server context #10670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
changed the title
JaroslavTulach
changed the title
JaroslavTulach
commented
Jul 26, 2024
JaroslavTulach
commented
Jul 26, 2024
...server/src/main/java/org/enso/languageserver/boot/resource/TruffleContextInitialization.java
Show resolved
Hide resolved
JaroslavTulach
commented
Jul 26, 2024
| .options(options); | ||
|
|
||
| if (inspect) { | ||
| options.put("inspect", ""); |
There was a problem hiding this comment.
I realized that when one uses --inspect and hit Debug.breakpoint statement we actually hit the breakpoint twice. Once in Chrome Dev Tools and once in REPL. I believe it is better to have just a single debugger running. As such I am proposing to disable debug server when --inspect option is used.
Akirathan
approved these changes
Jul 26, 2024
radeusgd
reviewed
Jul 26, 2024
hubertp
approved these changes
Jul 28, 2024
| .allowAllAccess(true) | ||
| .allowHostAccess(new HostAccessFactory().allWithTypeMapping()) | ||
| .option(RuntimeOptions.PROJECT_ROOT, pkg.root.getCanonicalPath) | ||
| .option("js.foreign-object-prototype", "true") |
There was a problem hiding this comment.
This option is no longer needed?
There was a problem hiding this comment.
I don't know what that option is good for?
In any case, it is not used by CLI. I see two PRs that refer to that option:
There were no failed tests when the option was removed, so it is not essential for any use-case we test for.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Move
ContextFactoryto common module, so it is also available inlanguage-servermodule and can be used there as well. As a result the initialization of experimental Espresso support is now unified. Otherwise this PR is just a refactoring except a single change: when using--inspectand--runhittingStandard.Base.Runtime.Debug.breakpointstatement, the debugger stops in Chrome Dev Tools, as the internal debug server is disabled.Checklist
Scala,
Java,