Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to eslint 7.23.0 #652

Merged
merged 4 commits into from
Apr 6, 2021
Merged

fix: update to eslint 7.23.0 #652

merged 4 commits into from
Apr 6, 2021

Conversation

erights
Copy link
Contributor

@erights erights commented Apr 5, 2021

No description provided.

@erights erights self-assigned this Apr 5, 2021
@erights
Copy link
Contributor Author

erights commented Apr 5, 2021

https://github.com/endojs/endo/pull/652/checks?check_run_id=2267215705 is a lint error that happens only under CI, not locally. The fixes at 58c8d3a are meant to address that, but make no local difference.

@erights
Copy link
Contributor Author

erights commented Apr 5, 2021

CI lint was satisfied by those changes. They all have in common a mention of globalThis.eval that does not bother local lint.

@erights
Copy link
Contributor Author

erights commented Apr 5, 2021

We've decided not to move forward with these at this time.

@erights erights marked this pull request as draft April 5, 2021 04:11
@erights erights marked this pull request as ready for review April 6, 2021 04:18
@erights erights requested review from dckc and kriskowal April 6, 2021 04:50
@erights erights changed the title fix: update eslint version fix: update to eslint 7.23.0 Apr 6, 2021
@erights erights merged commit e9199f4 into master Apr 6, 2021
@erights erights deleted the eslint-version branch April 6, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants