Skip to content

Commit

Permalink
fix: update to eslint 7.23.0 (#652)
Browse files Browse the repository at this point in the history
* fix: update to eslint 7.23.0
  • Loading branch information
erights authored Apr 6, 2021
1 parent 5e5dd01 commit e9199f4
Show file tree
Hide file tree
Showing 8 changed files with 241 additions and 114 deletions.
2 changes: 1 addition & 1 deletion packages/base64/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@rollup/plugin-node-resolve": "^6.1.0",
"ava": "^3.12.1",
"babel-eslint": "^10.0.3",
"eslint": "^6.8.0",
"eslint": "^7.23.0",
"eslint-config-airbnb-base": "^14.0.0",
"eslint-config-prettier": "^6.9.0",
"eslint-plugin-eslint-comments": "^3.1.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
},
"devDependencies": {
"@typescript-eslint/parser": "^4.18.0",
"eslint": "^6.8.0",
"eslint": "^7.23.0",
"eslint-config-airbnb": "^18.0.1",
"eslint-config-airbnb-base": "^14.0.0",
"eslint-config-jessie": "^0.0.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/make-hardener/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"@rollup/plugin-node-resolve": "^6.1.0",
"ava": "^3.12.1",
"babel-eslint": "^10.0.3",
"eslint": "^6.8.0",
"eslint": "^7.23.0",
"eslint-config-airbnb-base": "^14.0.0",
"eslint-config-prettier": "^6.9.0",
"eslint-plugin-eslint-comments": "^3.1.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/make-importer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"@rollup/plugin-node-resolve": "^6.1.0",
"ava": "^3.13.0",
"babel-eslint": "^10.0.3",
"eslint": "^6.8.0",
"eslint": "^7.23.0",
"eslint-config-airbnb-base": "^14.0.0",
"eslint-config-prettier": "^6.9.0",
"eslint-plugin-eslint-comments": "^3.1.2",
Expand Down
1 change: 1 addition & 0 deletions packages/ses/test/test-global-object-properties.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ test('globalObject properties', t => {

// eslint-disable-next-line no-eval
t.not(c.globalThis.eval, eval);
// eslint-disable-next-line no-eval
t.not(c.globalThis.eval, globalThis.eval);

t.not(c.globalThis.Function, Function);
Expand Down
1 change: 1 addition & 0 deletions packages/ses/test/test-global-object.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
test('globalObject', t => {
const intrinsics = {
Date: globalThis.Date,
// eslint-disable-next-line no-eval
eval: globalThis.eval,
Function: globalThis.Function,
globalThis: {},
Expand Down
2 changes: 2 additions & 0 deletions packages/ses/test/test-scope-handler.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,11 @@ test('scopeHandler - set trap', t => {
globalThis.bar = {};

const evil = {};
// eslint-disable-next-line no-eval
const originalEval = globalThis.eval;
handler.set(null, 'eval', evil);
t.is(globalObject.eval, evil);
// eslint-disable-next-line no-eval
t.is(globalThis.eval, originalEval);

const bar = {};
Expand Down
Loading

0 comments on commit e9199f4

Please sign in to comment.