Annotate httptools_impl.py
#1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
commented
May 10, 2022
adriangb
approved these changes
May 12, 2022
Comment on lines
+94
to
+95
| self.transport: asyncio.Transport = None # type: ignore[assignment] | ||
| self.flow: FlowControl = None # type: ignore[assignment] |
There was a problem hiding this comment.
Are you using the # type: ignore[assignment] just to avoid some assert self.transport is not Nones later?
Comment on lines
+40
to
+43
| if sys.version_info < (3, 8): # pragma: py-gte-38 | ||
| from typing_extensions import Literal | ||
| else: # pragma: py-lt-38 | ||
| from typing import Literal |
There was a problem hiding this comment.
do we have a _compat.py module or something where this sorta boilerplate can go?
| await self.send( | ||
| {"type": "http.response.body", "body": b"Internal Server Error"} | ||
| ) | ||
| self.on_response = lambda: None |
There was a problem hiding this comment.
This went from self.on_response = None to self.on_response = lambda: None`. The new version sounds more correct. Was this a bug?
There was a problem hiding this comment.
Good question. That was introduced on #189. I don't know if the line itself is really necessary (?)...
|
Thanks for the review @adriangb 🙏 |
Kludex
added a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
* Annotate `httptools_impl.py` * Update uvicorn/protocols/http/httptools_impl.py
Kludex
added a commit
that referenced
this pull request
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h11_impl.py#1397