Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break cyclical references #189

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Break cyclical references #189

merged 1 commit into from
Sep 5, 2018

Conversation

tomchristie
Copy link
Member

Break cyclical references that were causing the GC to run during request/response cycles and incur significant latencies on some requests.

This does remove the response timeouts for now.

We'll want an alternative implementation of the response timeouts, but we want a different approach there anyways (eg. timeout on no-data after a given period) to allow for long-running connections (eg. SSE).

@tomchristie tomchristie merged commit 0aca7aa into master Sep 5, 2018
@tomchristie tomchristie deleted the break-cyclical-references branch September 5, 2018 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant