Cover httptools_impl on mypy #1102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
commented
Jul 9, 2021
| WSGIApp = Callable[[Environ, StartResponse], Union[Iterable[bytes], BaseException]] | ||
|
|
||
|
|
||
| class WebProtocol(Protocol): |
There was a problem hiding this comment.
Here, I'm not sure if we should actually call it WebProtocolProtocol, because the Protocol is from typing. 🤔
Kludex
commented
Jul 9, 2021
| @@ -0,0 +1,16 @@ | |||
| import asyncio | |||
There was a problem hiding this comment.
I had to move this due to circular import on the WebProtocol. 😢
There was a problem hiding this comment.
11 hours after doing this, I wonder if this is a good idea. It's a breaking change as we were exposing ServerState on server.py. I can't find a better solution, so suggestions are welcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1014 by @jkklapp .