Typing/added typing to httptools_impl.py module #1014
Conversation
jkklapp
changed the title
|
wip |
|
@Kludex I added some |
|
@Kludex bump :) |
| if self.write_paused: | ||
| self.write_paused = False | ||
| self._is_writable_event.set() | ||
|
|
||
|
|
||
| async def service_unavailable(scope, receive, send): | ||
| async def service_unavailable(scope: Scope, receive: Callable, send: Callable) -> None: |
There was a problem hiding this comment.
The idea is to follow asgiref. One of my PRs already have the types for receive and send.
| self, | ||
| config: Config, | ||
| server_state: ServerState, | ||
| _loop: asyncio.AbstractEventLoop = None, |
There was a problem hiding this comment.
| _loop: asyncio.AbstractEventLoop = None, | |
| _loop: Optional[asyncio.AbstractEventLoop] = None, |
| self.server: Optional[Tuple[str, int]] = None | ||
| self.client: Optional[Tuple[str, int]] = None | ||
| self.scheme: str | ||
| self.pipeline: list = [] |
| self.expect_100_continue = False | ||
| self.cycle = None | ||
| self.cycle: RequestResponseCycle = None # type: ignore |
There was a problem hiding this comment.
Why ignoring?
| self.cycle: RequestResponseCycle = None # type: ignore | |
| self.cycle: Optional[RequestResponseCycle] = None # type: ignore |
| self.headers = None | ||
| self.url: Optional[str] = None | ||
| self.scope: dict = {} | ||
| self.headers: list = [] |
|
|
||
| # Protocol interface | ||
| def connection_made(self, transport): | ||
| def connection_made(self, transport: asyncio.Transport) -> None: # type: ignore |
| @@ -262,7 +272,7 @@ def on_headers_complete(self): | |||
|
|
|||
| existing_cycle = self.cycle | |||
| self.cycle = RequestResponseCycle( | |||
| scope=self.scope, | |||
| scope=self.scope, # type: ignore | |||
| self.expected_content_length = 0 | ||
|
|
||
| # ASGI exception wrapper | ||
| async def run_asgi(self, app): | ||
| async def run_asgi(self, app: Callable) -> None: |
There was a problem hiding this comment.
Too generic. One of my PRs have this already, or even the current one already has? Not sure.
| @@ -435,7 +445,7 @@ async def send_500_response(self): | |||
| ) | |||
|
|
|||
| # ASGI interface | |||
| async def send(self, message): | |||
| async def send(self, message: dict) -> None: | |||
There was a problem hiding this comment.
asgiref. One of my PRs already has the Message type.
| @@ -544,7 +554,7 @@ async def send(self, message): | |||
| msg = "Unexpected ASGI message '%s' sent, after response already completed." | |||
| raise RuntimeError(msg % message_type) | |||
|
|
|||
| async def receive(self): | |||
| async def receive(self) -> Dict: | |||
|
@Kludex I have been checking your PRs to add the correct types however Im getting mypy issues I am struggling to solve. Hence I added more lines with Is it useful if I paste some mypy outputs here? |
|
I don't know... Probably not to be honest. But we can try. I've tried to crack this file before, but I felt like it depends on other stuff to be merged before 😞 |
|
@jkklapp We're now more active on those PRs. We've choose to make use of asgiref typing module instead of the |
|
@jkklapp Thanks for the efforts! I'll take the lead now. 😄 |
Part of #998