Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into ts-migration #2732

Closed
wants to merge 29 commits into from
Closed

Conversation

srmagura
Copy link
Contributor

Includes one small commit (6c652d9) by me. That commit fixes a dtslint error in @emotion/styled when using TypeScript 4.7.

Jack-Works and others added 18 commits March 10, 2022 12:10
…current `cache.sheet` (emotion-js#2677)

* chore: add custom sheet

* chore: add changeset

* chore: remove unused import

* chore: apply patch

* fix inline snapshots

* Fix Flow error

* tweak changeset

Co-authored-by: Mateusz Burzyński <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* docs: fix cache-provider demo rendering

* docs: fix cache-provider mdx

* docs: add stub implementation of customPlugin
…ble styles printing

[@emotion/jest] Add `includeStyles` option to `createSerializer`
… `var()` (emotion-js#2700)

* Allow for CSS variables in content property

* Update tests

* Fixup tests

* Create young-deers-cheat.md

Co-authored-by: Mateusz Burzyński <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…y added `includeStyles` option (emotion-js#2715)

* pass includeStyles arg through

* add changeset entry

* Update .changeset/hot-seals-promise.md

Co-authored-by: Mateusz Burzyński <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The link was pointing to an old sandbox that used Emotion 10. This link
points to a new sandbox in the Emotion CodeSandbox org that uses Emotion
11.
@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2022

🦋 Changeset detected

Latest commit: b45662d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@emotion/serialize Patch
@emotion/cache Patch
@emotion/sheet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@srmagura srmagura requested a review from Andarist April 24, 2022 02:19
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 24, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b45662d:

Sandbox Source
Emotion Configuration

@codecov
Copy link

codecov bot commented Apr 24, 2022

@srmagura
Copy link
Contributor Author

All right, fixed both of those issues so this should be good to go now.

srmagura and others added 2 commits April 24, 2022 13:16
* chore: do not escape strings in snapshots

* Update jest.config.js

Co-authored-by: Mateusz Burzyński <[email protected]>

* update again

* react 18

Co-authored-by: Mateusz Burzyński <[email protected]>
Andarist and others added 6 commits April 28, 2022 23:38
* Allow any Node, including ShadowRoot, as container

* Add changeset

* Update container types in documentation to `Node`

* Update packages/sheet/src/index.js

Co-authored-by: Sam Magura <[email protected]>

* Update .changeset/five-balloons-sneeze.md

Co-authored-by: Sam Magura <[email protected]>

* remove a trailing whitespace

* `before` should be a `ChildNode`

Since `Node['firstChild']` is `ChildNode`, not `Element`.

Co-authored-by: Mateusz Burzyński <[email protected]>

* Add `.d.ts` test

* tweak changeset

Co-authored-by: Sam Magura <[email protected]>
Co-authored-by: Mateusz Burzyński <[email protected]>
* Update "no component selectors" error message

The message now references the swc Emotion plugin which also supports
component selectors, like @emotion/babel-plugin.

* Add changeset for "no component selecters" error message change

* Update .changeset/big-years-relate.md

Co-authored-by: Mateusz Burzyński <[email protected]>
@srmagura
Copy link
Contributor Author

The Preconstruct upgrade forced me to do some "creative" TypeScripting, see b45662d. This was all done to circumvent the error:

🎁 error Generating TypeScript declarations for packages/eslint-plugin/src/index.ts failed:
🎁 error packages/eslint-plugin/src/index.ts:8:14 - error TS2742: The inferred type of 'rules' cannot be named without a reference to '@typescript-eslint/experimental-utils/node_modules/@typescript-eslint/types/dist/ast-spec'. This is likely not portable. A type annotation is necessary.
🎁 error
🎁 error 8 export const rules = {
🎁 error                ~~~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants