-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow any Node, including ShadowRoot, as container #2728
Conversation
🦋 Changeset detectedLatest commit: 21d4bd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 21d4bd8:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👏. Left two suggestions.
Co-authored-by: Sam Magura <[email protected]>
Co-authored-by: Sam Magura <[email protected]>
Thanks! I've committed those suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙏. Looks like ESLint is complaining about a trailing space in packages/sheet/src/index.js
. Can you run Prettier on that file and push the change? I would push to your branch but I don't have write access to the repo.
@Andarist ready for you to review
Since `Node['firstChild']` is `ChildNode`, not `Element`. Co-authored-by: Mateusz Burzyński <[email protected]>
Good catch, @Andarist, thanks! Added. |
What:
container
in@emotion/sheet
and@emotion/cache
toNode
.ShadowRoot
as acontainer
.Why:
When using Shadow DOM, stylesheets are scoped to the shadow DOM tree they appear in. The most common place to put them is at the shadow root. But a
ShadowRoot
, though it containsHTMLElement
s, is not itself anHTMLElement
, though it is aNode
. The types only allowedHTMLElement
s as thecontainer
, but as the code is written, anyNode
should work. The added test validates that.How:
Broadens a type in a few places and adds one test.
Checklist: