-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@emotion/jest] Pass through includeStyles
option in createEnzymeSerializer
#2715
Conversation
🦋 Changeset detectedLatest commit: a3250b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a3250b0:
|
Codecov Report
|
@@ -66,11 +66,13 @@ const wrappedEnzymeSerializer = { | |||
|
|||
export function createEnzymeSerializer({ | |||
classNameReplacer, | |||
DOMElements = true | |||
DOMElements = true, | |||
includeStyles = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might also need to add this in the .d.ts
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createEnzymeSerializer
uses the same CreateSerializerOptions
interface as createSerializer
(updated with includeStyles
in #2709). In enzyme.d.ts
, imported from index.d.ts
. Or are you referring to a different d.ts
file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is fine. I was reviewing from mobile and I've assumed that there is another type for this one.
What: Add the missing
includeStyles
option tocreateEnzymeSerializer
Why: The option was added to
createSerializer
in #2709, but was not added tocreateEnzymeSerializer
How: The option is accepted and passed through to
createEmotionSerializer