-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Room screen: timeline message bubbles #91
Conversation
ElementX/Sources/Screens/RoomScreen/View/TimelineItemStylerView.swift
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #91 +/- ##
===========================================
+ Coverage 24.18% 24.49% +0.31%
===========================================
Files 136 137 +1
Lines 9804 10037 +233
Branches 4889 4948 +59
===========================================
+ Hits 2371 2459 +88
- Misses 7363 7505 +142
- Partials 70 73 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unnecessarily excited about seeing this land! 👏 Have added some thoughts :)
For the correct colours in dark mode I think we need a .background(Color.element.background)
on the room screen now.
Also, adding a .foregroundColor(.element.primaryContent)
onto the FormattedBodyText
/Text
views of the item views will make this look perfect 👌
ElementX/Sources/Screens/RoomScreen/View/Timeline/PlaceholderAvatarImage.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Timeline/TextRoomTimelineView.swift
Show resolved
Hide resolved
ElementX/Sources/Services/Timeline/RoomTimelineController.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Timeline/EventBasedTimelineSenderView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Timeline/EventBasedTimelineSenderView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/TimelineItemStylerView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/TimelineItemStylerView.swift
Outdated
Show resolved
Hide resolved
Changes in 91 (2022-06-23)✨ Features
🙌 Improvements
🐛 Bugfixes
🧱 Build 📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Vgcozw |
ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemFactory.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Timeline/EventBasedTimelineSenderView.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫧 Looks great to me! 💬
Couple of minor comments added, although I think GH messed up not sure if they all posted.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fixes #34