Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room screen: timeline message bubbles #91

Merged
merged 23 commits into from
Jun 23, 2022

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Jun 22, 2022

Fixes #34

Light Dark
Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-22 at 18 09 40 Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-22 at 18 09 29
Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-22 at 18 15 08 Simulator Screen Shot - iPhone 13 Pro Max - 2022-06-22 at 18 15 21

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #91 (9c6680d) into develop (5df1411) will increase coverage by 0.31%.
The diff coverage is 33.97%.

@@             Coverage Diff             @@
##           develop      #91      +/-   ##
===========================================
+ Coverage    24.18%   24.49%   +0.31%     
===========================================
  Files          136      137       +1     
  Lines         9804    10037     +233     
  Branches      4889     4948      +59     
===========================================
+ Hits          2371     2459      +88     
- Misses        7363     7505     +142     
- Partials        70       73       +3     
Impacted Files Coverage Δ
ElementX/Sources/AppCoordinator.swift 0.00% <0.00%> (ø)
...X/Sources/Screens/HomeScreen/View/HomeScreen.swift 0.00% <0.00%> (ø)
...omScreen/View/Timeline/EmoteRoomTimelineView.swift 0.00% <0.00%> (ø)
...s/RoomScreen/View/Timeline/FormattedBodyText.swift 0.00% <0.00%> (ø)
...omScreen/View/Timeline/ImageRoomTimelineView.swift 0.00% <0.00%> (ø)
...mScreen/View/Timeline/NoticeRoomTimelineView.swift 0.00% <0.00%> (ø)
...ces/Services/Timeline/RoomTimelineController.swift 0.00% <0.00%> (ø)
...meline/TimelineItems/RoomTimelineItemFactory.swift 0.00% <0.00%> (ø)
...ntX/Sources/Screens/BugReport/View/BugReport.swift 85.14% <30.00%> (-1.59%) ⬇️
...mScreen/View/Timeline/PlaceholderAvatarImage.swift 48.38% <30.00%> (-8.76%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df1411...9c6680d. Read the comment docs.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unnecessarily excited about seeing this land! 👏 Have added some thoughts :)

For the correct colours in dark mode I think we need a .background(Color.element.background) on the room screen now.

Also, adding a .foregroundColor(.element.primaryContent) onto the FormattedBodyText/Text views of the item views will make this look perfect 👌

@github-actions
Copy link

github-actions bot commented Jun 23, 2022

Changes in 91 (2022-06-23)

✨ Features

  • Implement rageshake service. (#23)
  • Add filtering for rooms by name. (#26)
  • Settings screen minimal implementation. (#37)
  • DesignKit: Add initial implementation of DesignKit to the repo as a Swift package. (#43)

🙌 Improvements

  • Room: Use bubbles in the timeline. (#34)
  • Room: Add header view containing room avatar and encryption badge. (#35)
  • Add a UserSessionStore and the splash screen from Element iOS. (#40)
  • DesignKit: Add DesignKit to the ElementX project, style the login screen with it and tint the whole app. (#43)
  • Settings: Auto dismiss bug report screen and show a success indicator when bug report completed. (#76)
  • Bug report: Add GH labels. (#77)
  • Danger: Add a check for png files and warn to use SVG and PDF files. (#87)

🐛 Bugfixes

  • ElementInfoPlist: Use custom template for Info.plist. (#71)

🧱 Build

  • Use v0.0.1 of the DesignTokens package. (#78)
  • Update to v0.0.2 of the DesignTokens package. (#90)

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Vgcozw

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫧 Looks great to me! 💬

Couple of minor comments added, although I think GH messed up not sure if they all posted.

ElementX/Sources/Screens/Settings/View/Settings.swift Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ismailgulek ismailgulek merged commit b6b8b4b into develop Jun 23, 2022
@ismailgulek ismailgulek deleted the ismail/34_timeline_bubbles branch June 23, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Room screen: Timeline UI
3 participants