add Recents category drag & drop #23
Merged
+466
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the cell selection and its moving (with tableview);
the drag and drop is implemented : the cell can be move in the recents sections.
add traces.
Add the cell drag and drop.
fix a refresh issue.
fix some crashes
Hide the moving cell.
fix a refresh issue / crash after updating the room order.
remove the debug background color.
fix a crash when the move is cancelled.
-> the moving room was not always the expected one -> update after SDK update (room tag order computation)
| /** | ||
| The movingCellBackgroundImage; | ||
| */ | ||
| @property (nonatomic) UIImageView* movingCellBackGroundView; |
There was a problem hiding this comment.
I suggest replace "moving" prefix with "dropping"
Updates after internal reviews
aaronraimist
pushed a commit
to aaronraimist/riot-ios
that referenced
this pull request
Feb 5, 2019
Display all the joined rooms in the tab "Conversations"
This was referenced May 31, 2022
This was referenced Jun 8, 2022
This was referenced Jun 17, 2022
This was referenced Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.