-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UserSessionStore and SplashScreen. #82
Conversation
Generated by 🚫 Danger Swift against 059c440 |
eef4d72
to
bf50974
Compare
Update SplashScreen for EXI
66f4955
to
f32e228
Compare
f32e228
to
b982122
Compare
@@ -111,27 +104,36 @@ class AppCoordinator: AuthenticationCoordinatorDelegate, Coordinator { | |||
private func setupStateMachine() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we increase this rule perhaps? Or maybe just disable it for this one method as its clearly going to grow more.
Codecov Report
@@ Coverage Diff @@
## develop #82 +/- ##
===========================================
+ Coverage 16.10% 17.37% +1.26%
===========================================
Files 121 131 +10
Lines 9302 9630 +328
Branches 4690 4823 +133
===========================================
+ Hits 1498 1673 +175
- Misses 7757 7905 +148
- Partials 47 52 +5
Continue to review full report at Codecov.
|
Changes in 82 (2022-06-16)✨ Features
🙌 Improvements
🐛 Bugfixes
🧱 Build
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/1QMkxh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👏
ElementX/Sources/Screens/Authentication/AuthenticationCoordinator.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/Authentication/AuthenticationMetrics.swift
Outdated
Show resolved
Hide resolved
Only log out of the specific account. Add tests for the keychain controller. Expand test coverage. PR comments
7cb3265
to
059c440
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR makes the following changes:
Note: I've left the splash screen as handled by the authentication coordinator so that you can pop from the login screen back to it like in EI.