Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UserSessionStore and SplashScreen. #82

Merged
merged 4 commits into from
Jun 16, 2022
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jun 14, 2022

This PR makes the following changes:

  • Adds the FTUE splash screen from EI with a single button for login.
  • Adds a UserSessionStore and updates the state machine for this change (in a separate commit so easier to review).
  • Replaces the code block background colour with one from DesignKit.

Note: I've left the splash screen as handled by the authentication coordinator so that you can pop from the login screen back to it like in EI.

Simulator Screen Shot - iPhone 13 - 2022-06-14 at 18 31 26

@github-actions
Copy link

github-actions bot commented Jun 14, 2022

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by 🚫 Danger Swift against 059c440

@pixlwave pixlwave force-pushed the doug/ftue_splash branch 2 times, most recently from 66f4955 to f32e228 Compare June 14, 2022 17:21
@pixlwave pixlwave requested review from a team and stefanceriu and removed request for a team June 14, 2022 17:38
@@ -111,27 +104,36 @@ class AppCoordinator: AuthenticationCoordinatorDelegate, Coordinator {
private func setupStateMachine() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we increase this rule perhaps? Or maybe just disable it for this one method as its clearly going to grow more.

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2022

Codecov Report

Merging #82 (b982122) into develop (272fc50) will increase coverage by 1.26%.
The diff coverage is 33.70%.

❗ Current head b982122 differs from pull request most recent head 7cb3265. Consider uploading reports for the commit 7cb3265 to get more accurate results

@@             Coverage Diff             @@
##           develop      #82      +/-   ##
===========================================
+ Coverage    16.10%   17.37%   +1.26%     
===========================================
  Files          121      131      +10     
  Lines         9302     9630     +328     
  Branches      4690     4823     +133     
===========================================
+ Hits          1498     1673     +175     
- Misses        7757     7905     +148     
- Partials        47       52       +5     
Impacted Files Coverage Δ
ElementX/Sources/AppCoordinator.swift 0.00% <0.00%> (ø)
ElementX/Sources/AppCoordinatorStateMachine.swift 0.00% <0.00%> (ø)
ElementX/Sources/Generated/Assets.swift 51.28% <ø> (-5.65%) ⬇️
...tUI/Views/ViewFrameReader/FramePreferenceKey.swift 0.00% <0.00%> (ø)
...ens/Authentication/AuthenticationCoordinator.swift 0.00% <0.00%> (ø)
...rces/Services/UserSession/KeychainController.swift 0.00% <ø> (ø)
...ources/Services/UserSession/UserSessionStore.swift 0.00% <0.00%> (ø)
...s/Screens/SplashScreen/SplashScreenViewModel.swift 17.64% <17.64%> (ø)
...Screens/SplashScreen/SplashScreenCoordinator.swift 35.29% <35.29%> (ø)
...urces/Screens/SplashScreen/View/SplashScreen.swift 46.15% <46.15%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272fc50...7cb3265. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jun 14, 2022

Changes in 82 (2022-06-16)

✨ Features

  • Implement rageshake service. (#23)
  • Add filtering for rooms by name. (#26)
  • DesignKit: Add initial implementation of DesignKit to the repo as a Swift package. (#43)

🙌 Improvements

  • Add a UserSessionStore and the splash screen from Element iOS. (#40)
  • DesignKit: Add DesignKit to the ElementX project, style the login screen with it and tint the whole app. (#43)

🐛 Bugfixes

  • ElementInfoPlist: Use custom template for Info.plist. (#71)

🧱 Build

  • Use v0.0.1 of the DesignTokens package. (#78)

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/1QMkxh

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👏

ElementX/Sources/AppCoordinator.swift Show resolved Hide resolved
ElementX/Sources/AppCoordinator.swift Outdated Show resolved Hide resolved
ElementX/Sources/Other/String.swift Outdated Show resolved Hide resolved
Only log out of the specific account.
Add tests for the keychain controller.
Expand test coverage.
PR comments
@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave merged commit 8653f1d into develop Jun 16, 2022
@pixlwave pixlwave deleted the doug/ftue_splash branch June 16, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants