Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room screen: Timeline UI #34

Closed
manuroe opened this issue May 4, 2022 · 0 comments · Fixed by #91
Closed

Room screen: Timeline UI #34

manuroe opened this issue May 4, 2022 · 0 comments · Fixed by #91
Assignees
@ismailgulek
Labels
A-Timeline X-Needs-Design Z-BBQ-Alpha Required for ElementX - BBQ - Alpha

Comments

@manuroe
Copy link
Member

manuroe commented May 4, 2022 •
edited by VolkerJunginger
Loading

We only know that ElementX will use message bubbles.

Can we reuse the design recently implemented on EI?
@manuroe manuroe added Z-BBQ-Alpha Required for ElementX - BBQ - Alpha X-Needs-Design A-Timeline labels May 4, 2022
@manuroe manuroe mentioned this issue May 4, 2022
Closed
@ismailgulek ismailgulek self-assigned this Jun 21, 2022
ismailgulek added a commit that referenced this issue Jun 22, 2022
@ismailgulek
#34 Create TimelineItemStylerView
a8a93ec
ismailgulek added a commit that referenced this issue Jun 22, 2022
@ismailgulek
#34 Add styler view into different type of cells
d959b9b
ismailgulek added a commit that referenced this issue Jun 22, 2022
@ismailgulek
#34 Use placeholder avatar image on room list
0050766
ismailgulek added a commit that referenced this issue Jun 22, 2022
@ismailgulek
#34 Add isOutgoing param to event based timeline item
1d1324b
ismailgulek added a commit that referenced this issue Jun 22, 2022
@ismailgulek
#34 Compute isOutgoing for timeline items
9b89841
ismailgulek added a commit that referenced this issue Jun 22, 2022
@ismailgulek
#34 Update sender info view in timeline
f8097bc
ismailgulek added a commit that referenced this issue Jun 22, 2022
@ismailgulek
#34 Update mock timeline items
8c05a63
ismailgulek added a commit that referenced this issue Jun 22, 2022
@ismailgulek
#34 Rename EventBasedTimelineView to EventBasedTimelineSenderView
1782f64
ismailgulek added a commit that referenced this issue Jun 22, 2022
@ismailgulek
#34 Change padding on timeline cells
f444d5e
ismailgulek added a commit that referenced this issue Jun 22, 2022
@ismailgulek
#34 Create TimelineItemStylerView to move content into a bubble if …
133ed25 
…needed
ismailgulek added a commit that referenced this issue Jun 22, 2022
@ismailgulek
#34 Use styler view in all of the timeline item views
19a8630
ismailgulek added a commit that referenced this issue Jun 22, 2022
@ismailgulek
#34 Make timestamp more readable on images
9d7608c
ismailgulek added a commit that referenced this issue Jun 22, 2022
@ismailgulek
#34 Little layout tweaks
b4f82c1
ismailgulek added a commit that referenced this issue Jun 22, 2022
@ismailgulek
#34 Add changelog
a3ac72d
@ismailgulek ismailgulek mentioned this issue Jun 22, 2022
Merged
ismailgulek added a commit that referenced this issue Jun 22, 2022
@ismailgulek
#34 Fix code smells
c3e87b3
ismailgulek added a commit that referenced this issue Jun 23, 2022
@ismailgulek
#34 Set text colors on timeline items
cf986a3
ismailgulek added a commit that referenced this issue Jun 23, 2022
@ismailgulek
#34 Fix background color of the timeline
9992adc
ismailgulek added a commit that referenced this issue Jun 23, 2022
@ismailgulek
#34 Fix PR remarks
1c30dcf
ismailgulek added a commit that referenced this issue Jun 23, 2022
@ismailgulek
#34 Set background colors explicitly on remaining screens
9c6680d
ismailgulek added a commit that referenced this issue Jun 23, 2022
@ismailgulek
#34 Reduce min bubble width and make it a scaled metric
25fb6ce
ismailgulek added a commit that referenced this issue Jun 23, 2022
@ismailgulek
#34 Refactor PlaceholderAvatarImage to accept a text only
f742baa
ismailgulek added a commit that referenced this issue Jun 23, 2022
@ismailgulek
#34 Fix code smell
b8da33b
ismailgulek added a commit that referenced this issue Jun 23, 2022
@ismailgulek
#34 Fix further comments
26900ba
ismailgulek added a commit that referenced this issue Jun 23, 2022
@ismailgulek
Room screen: timeline message bubbles (#91)
b6b8b4b 
* #34 Create `TimelineItemStylerView`

* #34 Add styler view into different type of cells

* #34 Use placeholder avatar image on room list

* #34 Add `isOutgoing` param to event based timeline item

* #34 Compute `isOutgoing` for timeline items

* #34 Update sender info view in timeline

* #34 Update mock timeline items

* #34 Rename `EventBasedTimelineView` to `EventBasedTimelineSenderView`

* #34 Change padding on timeline cells

* #34 Create `TimelineItemStylerView` to move content into a bubble if needed

* #34 Use styler view in all of the timeline item views

* #34 Make timestamp more readable on images

* #34 Little layout tweaks

* #34 Add changelog

* #34 Fix code smells

* #34 Set text colors on timeline items

* #34 Fix background color of the timeline

* #34 Fix PR remarks

* #34 Set background colors explicitly on remaining screens

* #34 Reduce min bubble width and make it a scaled metric

* #34 Refactor `PlaceholderAvatarImage` to accept a text only

* #34 Fix code smell

* #34 Fix further comments
This was referenced Jun 27, 2022
Merged
Merged
Merged
@stefanceriu stefanceriu mentioned this issue Jun 29, 2022
Closed
This was referenced Jun 29, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 18, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ismailgulek ismailgulek

Labels
A-Timeline X-Needs-Design Z-BBQ-Alpha Required for ElementX - BBQ - Alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Room screen: timeline message bubbles element-hq/element-x-ios
2 participants
@ismailgulek @manuroe