-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session verification #122
Session verification #122
Conversation
8b0e903
to
75b21a6
Compare
Generated by 🚫 Danger Swift against 6bda2f6 |
7f28867
to
f9b058f
Compare
Changes in 122 (2022-07-01)✨ Features
🙌 Improvements
🐛 Bugfixes
🧱 Build
Others
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/AMDHmg |
Codecov Report
@@ Coverage Diff @@
## develop #122 +/- ##
===========================================
+ Coverage 26.92% 30.53% +3.60%
===========================================
Files 154 161 +7
Lines 10785 11423 +638
Branches 5256 5580 +324
===========================================
+ Hits 2904 3488 +584
- Misses 7797 7845 +48
- Partials 84 90 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woooo, great to have session verification land 👏
Sorry quite a few comments, hopefully most are minor.
ElementX/Sources/Services/SessionVerification/MockSessionVerificationControllerProxy.swift
Show resolved
Hide resolved
ElementX/Sources/Services/SessionVerification/SessionVerificationControllerProxy.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/SessionVerification/View/SessionVerification.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/SessionVerification/View/SessionVerification.swift
Outdated
Show resolved
Hide resolved
f9b058f
to
6b25490
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of comments inline and I think you're still working on Done/Cancel button logic?
ElementX/Sources/Screens/SessionVerification/View/SessionVerification.swift
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR introduces the possibility to verify user sessions. It will wait for /sync responses to check if the current session is verified and if not show a banner on top of the home screen. Tapping the banner will open up the session verification dialog which will help the user through the flow.