Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session verification #122

Merged
merged 7 commits into from
Jul 1, 2022
Merged

Session verification #122

merged 7 commits into from
Jul 1, 2022

Conversation

stefanceriu
Copy link
Member

This PR introduces the possibility to verify user sessions. It will wait for /sync responses to check if the current session is verified and if not show a banner on top of the home screen. Tapping the banner will open up the session verification dialog which will help the user through the flow.
Screenshot 2022-06-30 at 12 58 14
Screenshot 2022-06-30 at 12 58 25

@stefanceriu stefanceriu requested review from a team and pixlwave and removed request for a team June 30, 2022 10:03
@github-actions
Copy link

github-actions bot commented Jun 30, 2022

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against 6bda2f6

@stefanceriu stefanceriu force-pushed the stefan/sessionVerification branch 2 times, most recently from 7f28867 to f9b058f Compare June 30, 2022 10:24
@github-actions
Copy link

github-actions bot commented Jun 30, 2022

Changes in 122 (2022-07-01)

✨ Features

  • Implement rageshake service. (#23)
  • Add filtering for rooms by name. (#26)
  • Settings screen minimal implementation. (#37)
  • DesignKit: Add initial implementation of DesignKit to the repo as a Swift package. (#43)
  • Room timeline: Add plain styler and add timeline option in settings screen. (#92)
  • Implement and use background tasks. (#99)

🙌 Improvements

  • Implement new ClientBuilder pattern for login (#120)
  • Flatten the room list by removing the encrypted groups. (#121)
  • Room: Use bubbles in the timeline. (#34)
  • Room: Add header view containing room avatar and encryption badge. (#35)
  • Add the splash, login and server selection screens from Element iOS along with a UserSessionStore. (#40)
  • DesignKit: Add DesignKit to the ElementX project, style the login screen with it and tint the whole app. (#43)
  • Settings: Auto dismiss bug report screen and show a success indicator when bug report completed. (#76)
  • Bug report: Add GH labels. (#77)
  • Danger: Add a check for png files and warn to use SVG and PDF files. (#87)
  • Add localizations to UI tests target and add some checks. (#101)

🐛 Bugfixes

  • ElementInfoPlist: Use custom template for Info.plist. (#71)

🧱 Build

  • Use v0.0.1 of the DesignTokens package. (#78)
  • Update to v0.0.2 of the DesignTokens package. (#90)
  • Fix Danger's changelog detection. (#74)

Others

  • Add Screen as a suffix to all screens and tidy up the template. (#125)
  • Fix project urls in Towncrier configuration. (#96)

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/AMDHmg

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #122 (6b25490) into develop (266ca65) will increase coverage by 3.60%.
The diff coverage is 55.90%.

@@             Coverage Diff             @@
##           develop     #122      +/-   ##
===========================================
+ Coverage    26.92%   30.53%   +3.60%     
===========================================
  Files          154      161       +7     
  Lines        10785    11423     +638     
  Branches      5256     5580     +324     
===========================================
+ Hits          2904     3488     +584     
- Misses        7797     7845      +48     
- Partials        84       90       +6     
Impacted Files Coverage Δ
ElementX/Sources/AppCoordinator.swift 0.00% <0.00%> (ø)
ElementX/Sources/AppCoordinatorStateMachine.swift 0.00% <0.00%> (ø)
...ces/Screens/HomeScreen/HomeScreenCoordinator.swift 0.00% <0.00%> (ø)
.../Sources/Screens/HomeScreen/HomeScreenModels.swift 9.09% <ø> (ø)
...X/Sources/Screens/HomeScreen/View/HomeScreen.swift 0.00% <0.00%> (ø)
ElementX/Sources/Services/Client/ClientProxy.swift 0.00% <0.00%> (ø)
ElementX/Sources/Services/Room/RoomProxy.swift 0.00% <0.00%> (ø)
...lementX/Sources/Services/Session/UserSession.swift 0.00% <0.00%> (ø)
...ification/SessionVerificationControllerProxy.swift 0.00% <0.00%> (ø)
...urces/Services/Timeline/RoomTimelineProvider.swift 0.00% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 266ca65...6b25490. Read the comment docs.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooo, great to have session verification land 👏
Sorry quite a few comments, hopefully most are minor.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of comments inline and I think you're still working on Done/Cancel button logic?

@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.5% 2.5% Duplication

@stefanceriu stefanceriu merged commit a6f9d1b into develop Jul 1, 2022
@stefanceriu stefanceriu deleted the stefan/sessionVerification branch July 1, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants