Add FindYourContactsFooterView to ContactsTableViewController #4709

pixlwave · 2021-08-13T15:05:28Z

The second part of the contacts portion of #4484. Depends upon matrix-org/matrix-ios-kit#879 and matrix-org/matrix-ios-sdk#1200.

A footer is added to ContactsTableViewController whenever the necessary permissions to display the user's contacts have not be granted. Rather than automatically prompting the user for contacts access whenever a ContactsTableViewController is shown, this is now prevented and waits until the user chooses to grant it.

Additionally fixes #4617 by removing the display of local contacts from Unified Search's People tab.

Add Identity Server explainer text for ℹ️ button. Possibly:

An identity server allows Element to find users on Matrix by looking up their phone number or email address.

Add Integration Manager explainer text for ℹ️ button. Possibly:

An integration manager allows you to add functionality from third parties into Element.
An integration manager allows you to add features to Element that are operated by third parties.
An integration manager connects additional services into the Matrix ecosystem, such as bots, bridges widgets, and sticker packs.

Review notes:

The NSContactsUsageDescription string has been updated in InfoPlist.strings. Is there anything extra that should be done for this?

Edit: The design below is out of date. There's a screen recording with the final design at the bottom of this PR

Update InviteFriendsHeaderView and StartChatViewController styles to match Figma doc.

Remove automatic triggering of contacts access.

Update the value of showLocalContacts in ContactsTableViewController.

…of showLocalContacts.

…ove identity server terms modal from LegacyAppDelegate into ContactsTableViewController.

…beneath the contacts.

… the setter.

pixlwave · 2021-08-13T15:19:28Z

Screenshot of how the changes look on an iPad - it currently matches the max width to the Invite Friends button:

pixlwave · 2021-08-13T15:31:07Z

Both the best case and worst case flows:

Outdated

https://user-images.githubusercontent.com/6060466/129382764-aac09642-dfae-48c0-b371-bdb38e2e6244.mov

bumpy-path-480p.mov

github-actions · 2021-08-17T15:36:52Z

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xgPnRi

Checkboxes have been removed from the individual policies. Reverse flow so that the service terms are show before the contacts access popup. Removes outOfContext from the modal as it will only be presented when requested. Fixes second presentation on swipe to dismiss of the modal.

…w an alert when there's an error.

…s launched.

…ntroller.

pixlwave · 2021-09-15T13:47:36Z

Updated both the footer view and the terms of service modal from the latest Figma. A recording of the flow with both identity server and contacts access:

export.mp4

The changes to terms of service modal also affect the integration manager which now looks like this:

…ewController.

# Conflicts: # Riot/Assets/en.lproj/Vector.strings # Riot/Generated/Strings.swift # Riot/Modules/Application/LegacyAppDelegate.m # Riot/Modules/Settings/SettingsViewController.m

stefanceriu

Small comments otherwise lgtm 👍

Riot/Modules/Settings/SettingsViewController.m

Riot/Modules/Contacts/Views/FindYourContactsFooterView.swift

Use the new generated localisation strings. Add comments. Address feedback from PR review.

niquewoodhouse · 2021-10-06T10:02:15Z

@pixlwave just looking at the text for the ℹ️s. I know there's a tone of voice being worked on so this might be temporary text.

Identity Server:
- An identity server helps you find your contacts, by looking up their phone number or email address, to see if they already have an account on Matrix.*
Integration manager:
- An integration manager lets you add features from third parties.

I personally am not sure the on matrix bit is that relevant but added in case its too controversial if not there.

pixlwave · 2021-10-06T10:37:52Z

Thanks, will update. Makes sense to me without the "on Matrix" bit.

…_access # Conflicts: # Riot/Modules/ServiceTerms/Modal/ServiceTermsModalCoordinatorBridgePresenter.swift

pixlwave added 21 commits July 23, 2021 16:34

Add quinary colour to themes.

c0bd505

Add RequestContactsAccessFooterView.

0244967

Update InviteFriendsHeaderView and StartChatViewController styles to match Figma doc.

Enable local contact sync if granted access. Improve layout.

387ef72

Update search bar string and appearance.

c47024e

Merge branch 'develop' into doug/4484_contacts_access

ae438e1

Move RequestContactsAccessFooterView into ContactsTableViewController.

b475afc

Remove automatic triggering of contacts access.

Fix image name.

e4c4f5e

Replace hasLocalContacts with showLocalContacts.

ddd9351

Update the value of showLocalContacts in ContactsTableViewController.

Hide local contacts in Unified Search.

a198237

Take into account the identity server when setting the default value …

d1b9c9e

…of showLocalContacts.

Disable the contact access footer view in Unified Search.

57e5534

Match StartChatViewController colours to latest Figma.

834cb7f

Use areAllTermsAgreed instead of hasAccountDataIdentityServerValue. M…

32f4fcc

…ove identity server terms modal from LegacyAppDelegate into ContactsTableViewController.

Merge branch 'develop' into doug/4484_contacts_access

0d48568

Fix bug where RequestContactsAccessFooterView could still be visible …

9619a3b

…beneath the contacts.

Localise contacts disabled alert strings.

8cc9340

Match NSContactsUsageDescription to Figma design.

68c9c01

Load contacts and/or the footer view before the view appears.

e82ed1f

Fix the footer when searching from StartChatViewController.

ef92a37

Check for unnecessary assignments to contactsAreFilteredWithSearch in…

9f3ab79

… the setter.

Move function.

42d13e2

pixlwave requested a review from niquewoodhouse August 17, 2021 12:19

Merge branch 'develop' into doug/4484_contacts_access

bfbed0a

pixlwave added 4 commits September 9, 2021 12:24

Merge branch 'develop' into doug/4484_contacts_access

94b996f

Update strings and add localise. Use theme v2.

b71649e

Revert search bar placeholder.

7fc8d1c

Update strings in SettingsViewController.

fb19253

pixlwave added 8 commits September 13, 2021 11:46

Show an activity indicator whilst preparing the identity service. Sho…

684b1fb

…w an alert when there's an error.

Call -MXKContactManager.validateSyncLocalContactsState when the app i…

4800ff3

…s launched.

Fix rotation layout bug. Update button title.

e5702c6

Rename RequestContactsAccessFooterView to FindYourContactsFooterView.

3198f7c

Fix FindYourContactsFooterView layout on 4" screens.

270c483

Add ServiceTermsModalTableHeaderView to ServiceTermsModalScreenViewCo…

8705191

…ntroller.

Improve layout of ServiceTermsModalScreenViewController on 4" devices.

f1a6666

pixlwave changed the title ~~Add RequestContactsAccessFooterView to ContactsTableViewController~~ Add FindYourContactsFooterView to ContactsTableViewController Sep 15, 2021

Fix landscape layout of ServiceTermsModalScreenViewController.

1f44991

pixlwave added 2 commits September 29, 2021 17:40

Add an image for the integration manager to ServiceTermsModalScreenVi…

7a46bb4

…ewController.

Merge branch 'develop' into doug/4484_contacts_access

b9dc5d6

# Conflicts: # Riot/Assets/en.lproj/Vector.strings # Riot/Generated/Strings.swift # Riot/Modules/Application/LegacyAppDelegate.m # Riot/Modules/Settings/SettingsViewController.m

pixlwave marked this pull request as ready for review September 30, 2021 14:44

stefanceriu approved these changes Oct 1, 2021

View reviewed changes

Riot/Modules/Settings/SettingsViewController.m Outdated Show resolved Hide resolved

Riot/Modules/Contacts/Views/FindYourContactsFooterView.swift Outdated Show resolved Hide resolved

Riot/Modules/Contacts/Views/FindYourContactsFooterView.swift Outdated Show resolved Hide resolved

Small tweaks plus changelog entry.

50d9952

Use the new generated localisation strings. Add comments. Address feedback from PR review.

pixlwave force-pushed the doug/4484_contacts_access branch from 0cbf747 to 50d9952 Compare October 1, 2021 15:16

Add final strings. Tweak header.

f130bb3

pixlwave mentioned this pull request Oct 8, 2021

Add an analytics value of accept/decline of identity server terms. #4957

Merged

pixlwave added 2 commits October 8, 2021 11:45

Merge remote-tracking branch 'origin/develop' into doug/4484_contacts…

bf52311

…_access # Conflicts: # Riot/Modules/ServiceTerms/Modal/ServiceTermsModalCoordinatorBridgePresenter.swift

Update Analytics from Steve's comments.

494987d

pixlwave merged commit 60bc34d into develop Oct 11, 2021

pixlwave deleted the doug/4484_contacts_access branch October 11, 2021 09:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add FindYourContactsFooterView to ContactsTableViewController #4709

Add FindYourContactsFooterView to ContactsTableViewController #4709

pixlwave commented Aug 13, 2021 •

edited

Loading

pixlwave commented Aug 13, 2021

pixlwave commented Aug 13, 2021 •

edited

Loading

github-actions bot commented Aug 17, 2021 •

edited

Loading

pixlwave commented Sep 15, 2021 •

edited

Loading

stefanceriu left a comment

niquewoodhouse commented Oct 6, 2021 •

edited

Loading

pixlwave commented Oct 6, 2021

Add FindYourContactsFooterView to ContactsTableViewController #4709

Add FindYourContactsFooterView to ContactsTableViewController #4709

Conversation

pixlwave commented Aug 13, 2021 • edited Loading

pixlwave commented Aug 13, 2021

pixlwave commented Aug 13, 2021 • edited Loading

github-actions bot commented Aug 17, 2021 • edited Loading

pixlwave commented Sep 15, 2021 • edited Loading

stefanceriu left a comment

Choose a reason for hiding this comment

niquewoodhouse commented Oct 6, 2021 • edited Loading

pixlwave commented Oct 6, 2021

pixlwave commented Aug 13, 2021 •

edited

Loading

pixlwave commented Aug 13, 2021 •

edited

Loading

github-actions bot commented Aug 17, 2021 •

edited

Loading

pixlwave commented Sep 15, 2021 •

edited

Loading

niquewoodhouse commented Oct 6, 2021 •

edited

Loading