Add an analytics value of accept/decline of identity server terms. #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/8AP6Sk |
| @@ -98,13 +100,36 @@ extension ServiceTermsModalCoordinatorBridgePresenter: ServiceTermsModalCoordina | |||
|
|
|||
| func serviceTermsModalCoordinatorDidAccept(_ coordinator: ServiceTermsModalCoordinatorType) { | |||
| self.delegate?.serviceTermsModalCoordinatorBridgePresenterDelegateDidAccept(self) | |||
|
|
|||
| if serviceType == MXServiceTypeIdentityService { | |||
There was a problem hiding this comment.
It's better if we put analytics inside Coordinator because BridgePresenters are only built for ObjC compatibility when we will remove the presenter we will loose the analytics.
|
As discussed I'll address this comment in #4709. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4955, this PR adds an analytics value of accept/decline of the identity server's terms. Depends on matrix-org/matrix-ios-kit#925.
In the context of this PR, a decline is being treated as dismissing without accepting, whether that's by tapping decline, cancel or swiping to dismiss.