-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove permission popups on a new sign in/up #4484
Comments
Testing with both develop and 1.4.3 from the App Store, I only seeing this pop-up when tapping the people tab? 😕 |
Android asks to send a crash log only after a crash occurred and doesn't yet have analytics, so there's no comparable prompt to match the behaviour to. |
It's worth noting as this may affect the choice around when to prompt for gathering logs:
|
Just want to set expectations, I think this might be a larger design challenge than a quick papercut, and it might take a bit of time to identify the right place to ask for contact access, and the right way to ask (copy + design). Especially if we're not able to test performance of the permissions. I'm very happy to work on this but it might be mid next week before we have some proposals to discuss around. |
Sure, makes sense. Thanks for letting me know 👍 |
I'd argue that it should pop up after a user has scrolled down in the People tab and saw "find people from contacts", and then press that banner. |
How are the logs currently used @manuroe + what's the aim with them? I'm wondering if moving them until after several uses means we'll lose the ability to spot issues that impact early retention because we'll not have that information anymore (only people who've returned several times will actually see this) |
@pixlwave I see there are other issues around this area like element-hq/element-meta#41 so I think I'll leave this one. I put some very early WIP here if it helps anyone working on that in the future |
@manuroe as we've redesigned the whole new flow and taken the pop-ups into consideration as we do, are you happy for us to close this issue and create new ones if we have new data based on the update that will land soon? |
yes, sure. |
We currently display 2 permission popups after logging in on a fresh app install:
This is too much for a new user. We should remove them.
The text was updated successfully, but these errors were encountered: