-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please remove dependency on @types/glob
which is not required and causes breakage in typedoc builds
#330
Comments
It seems there is some history here. The types were removed from Some intentional effort went into getting this types out of dependencies. Can this please be revisited? FYI @isaacs who did the work in #268. Do you know how this ended back up in deps? |
The regression happened in #320 |
No idea. I'm not involved with electron/asar, I just sent that PR because someone was complaining that glob exported the "wrong" types (for its own code, which is written in ts! lol) |
This can be reverted once electron/asar#330 is resolved.
🎉 This issue has been resolved in version 3.2.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The version of
@types/glob
that is used by this package is incompatible with newer versions of glob or minimatch. Those libraries are written directly in typescript (this wasn't the case before) so no types package is necessary. Please remove@types/glob
as a dependency.Some additional context where this has come up: isaacs/rimraf#264
The text was updated successfully, but these errors were encountered: