Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove dependency on @types/glob which is not required and causes breakage in typedoc builds #330

Closed
aaclayton opened this issue Oct 7, 2024 · 4 comments · Fixed by #336 or #339
Labels

Comments

@aaclayton
Copy link

aaclayton commented Oct 7, 2024

The version of @types/glob that is used by this package is incompatible with newer versions of glob or minimatch. Those libraries are written directly in typescript (this wasn't the case before) so no types package is necessary. Please remove @types/glob as a dependency.

Some additional context where this has come up: isaacs/rimraf#264

@aaclayton
Copy link
Author

It seems there is some history here. The types were removed from dependencies in #268 which was reviewed and merged, and then at some point it moved back into dependencies in current https://github.com/electron/asar/blob/main/package.json.

Some intentional effort went into getting this types out of dependencies. Can this please be revisited? FYI @isaacs who did the work in #268. Do you know how this ended back up in deps?

@aaclayton
Copy link
Author

The regression happened in #320

@isaacs
Copy link
Contributor

isaacs commented Oct 8, 2024

No idea. I'm not involved with electron/asar, I just sent that PR because someone was complaining that glob exported the "wrong" types (for its own code, which is written in ts! lol)

Hinton added a commit to bitwarden/clients that referenced this issue Oct 22, 2024
@erikian erikian linked a pull request Oct 24, 2024 that will close this issue
Copy link

🎉 This issue has been resolved in version 3.2.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants