-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete @types/gulp & @types/minimatch on posinstall #11509
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11509 +/- ##
=======================================
Coverage 33.17% 33.17%
=======================================
Files 2779 2779
Lines 86223 86223
Branches 16420 16420
=======================================
Hits 28604 28604
Misses 55353 55353
Partials 2266 2266 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update commit comment to mention when these hacks should be removed? Please do this through a rebase so that github will use the sole commit as the squash commit message
@MGibson1 I always manually write my merge commits, so a squash won't be needed. At this point I don't see this happening in the near future due to the electron maintainers perspective on the issue. |
The auto merge has the following message. "This can be reverted once electron/asar#330 is resolved." |
🎟️ Tracking
📔 Objective
Seems to work more reliably than the overrides. The root issue should be fixed when electron/asar#332 is merged.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes