Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete @types/gulp & @types/minimatch on posinstall #11509

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Oct 11, 2024

🎟️ Tracking

📔 Objective

Seems to work more reliably than the overrides. The root issue should be fixed when electron/asar#332 is merged.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from MGibson1 October 11, 2024 15:34
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.17%. Comparing base (f69e943) to head (52119b5).
Report is 88 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11509   +/-   ##
=======================================
  Coverage   33.17%   33.17%           
=======================================
  Files        2779     2779           
  Lines       86223    86223           
  Branches    16420    16420           
=======================================
  Hits        28604    28604           
  Misses      55353    55353           
  Partials     2266     2266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb9659e39-676c-489c-8df4-ae551bc998bb

No New Or Fixed Issues Found

Copy link
Member

@MGibson1 MGibson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update commit comment to mention when these hacks should be removed? Please do this through a rebase so that github will use the sole commit as the squash commit message

@Hinton
Copy link
Member Author

Hinton commented Oct 17, 2024

@MGibson1 I always manually write my merge commits, so a squash won't be needed. At this point I don't see this happening in the near future due to the electron maintainers perspective on the issue.

@Hinton Hinton enabled auto-merge (squash) October 17, 2024 18:45
@Hinton
Copy link
Member Author

Hinton commented Oct 17, 2024

The auto merge has the following message. "This can be reverted once electron/asar#330 is resolved."

@Hinton Hinton requested a review from MGibson1 October 17, 2024 18:45
@Hinton Hinton merged commit 801d9a8 into main Oct 22, 2024
66 checks passed
@Hinton Hinton deleted the arch/fix-package-lock branch October 22, 2024 17:58
coroiu added a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants