Revert "Delete @types/gulp & @types/minimatch on posinstall" #11787
Conversation
This reverts commit 801d9a8.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11787 +/- ##
=======================================
Coverage 33.54% 33.55%
=======================================
Files 2815 2815
Lines 87635 87635
Branches 16685 16685
=======================================
+ Hits 29397 29404 +7
+ Misses 55928 55921 -7
Partials 2310 2310 ☔ View full report in Codecov by Sentry. |
| "@electron/asar": { | ||
| "@types/glob": "7.1.3" | ||
| } |
There was a problem hiding this comment.
I don't think we need this any longer? Unsure if minimatch is needed either.
There was a problem hiding this comment.
I have no idea what any of this does, I just know minimatch is blocking lock-file maintenance, do you think we can remove minimatch entirely?
|
@coroiu can you provide more context for this? We need to first upgrade electron asar to the new version which inlines @types/gulp. Unfortunately they still depend on the old version of minimatch which probably causes conflicts with gulp. |
|
@Hinton #11509 (comment) says
And since that issue seems to be closed I opened this PR. I was hoping you had the context 😅 |
|
Yes, once we upgrade asar the types/gulp portion should be fixed, not sure about minimatch. But we first have to ensure we get the new asar package in, which means updating the lockfile. |
| "replacestream": "4.0.3", | ||
| "@types/minimatch": "3.0.5", | ||
| "@electron/asar": { | ||
| "@types/glob": "7.1.3" | ||
| } |
There was a problem hiding this comment.
This should work now, both type dependencies were gone from my lockfile.
| "replacestream": "4.0.3", | |
| "@types/minimatch": "3.0.5", | |
| "@electron/asar": { | |
| "@types/glob": "7.1.3" | |
| } | |
| "replacestream": "4.0.3" |
|
Closing since no longer needed |
Reverts #11509