fix(deps): update dependency app-builder-bin to v4.2.0

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
app-builder-bin	4.0.0 -> 4.2.0

---

Configuration

📅 Schedule: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6573840

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for car-park-attendant-cleat-11576 ready!

Name	Link
🔨 Latest commit	6573840
🔍 Latest deploy log	https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/65f3e86472caf900082380d3
😎 Deploy Preview	https://deploy-preview-7774--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[renovate]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

[mmaietta]

@develar seems there's still an issue with the latest app-builder-bin. I've added chmod to fix the executable permissions issue so that most tests are passing. It seems there's an issue resolving dependencies though with the latest app-builder-bin changes/version

  ● posix smart unpack

    ENOENT: no such file or directory, scandir '/tmp/et-db411cd21f3bbd882f3a5a30c58db6ff/t-2ACDjf/test-project-9/node_modules/are-we-there-yet/node_modules/core-util-is'

Please recommend how to best proceed 🙂

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[mmaietta]

@develar friendly ping. 🙂 I'm not sure how to proceed further here. Sounds like either something broke in app-builder and/or these are the follow-up action items develar/app-builder#84 (comment)
This also might be related: develar/app-builder#93

Can you confirm?

[renovate]

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (4.2.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

[beyondkmp]

@mmaietta Why close this PR? After this fix(mmaietta/app-builder#2), I tested the integration of the new app-builder with electron-builder, and the same error still occurs.

I noticed that in electron-builder, the path is directly concatenated, using the node modules path + the name of the deps.

electron-builder/packages/app-builder-lib/src/util/NodeModuleCopyHelper.ts

Line 67 in 00f46e6

const filePath = dirPath + path.sep + name

This approach doesn't work for the foo package inside a workspace. It seems necessary for app-builder to return the real paths of all dependencies, and then for electron-builder to directly use these paths instead of concatenating them on its own.

[mmaietta]

Looks like it was autoclosed by the PR when it was auto-linked to it. Will reopen it

[Galkon]

It will be majorly appreciated to see this merged + released in electron-builder, thank you all!

[mmaietta]

@Galkon I can't until app-builder has its issue fixed (and/or new release) and CI tests pass in this PR, until then I'm at an impasse.

[beyondkmp]

@mmaietta When returning from node-dep-tree, directly include the deps' dir, so we can use this dir without needing to concatenate anymore. Do you see any problems with this solution?

including the deps' dir result

[{"dir":"/tmp/et-db411cd21f3bbd882f3a5a30c58db6ff/t-4RhJzh/test-project-1/node_modules","deps":[{"name":"ms","version":"2.0.0","dir":"/tmp/et-db411cd21f3bbd882f3a5a30c58db6ff/t-4RhJzh/test-project-1/node_modules/ms"}]},{"dir":"/tmp/et-db411cd21f3bbd882f3a5a30c58db6ff/t-4RhJzh/test-project-1/packages/test-app/node_modules","deps":[{"name":"foo","version":"1.0.0","dir":"/tmp/et-db411cd21f3bbd882f3a5a30c58db6ff/t-4RhJzh/test-project-1/packages/foo"},{"name":"ms","version":"2.1.1","dir":"/tmp/et-db411cd21f3bbd882f3a5a30c58db6ff/t-4RhJzh/test-project-1/packages/test-app/node_modules/ms"}]}

[mmaietta]

@beyondkmp is that an app-builder change or an electron-builder change?

Currently checking if I can get write access to app-builder to help unblock PRs on that package

[beyondkmp]

@mmaietta
It looks like modifications are needed on both sides. The app-builder needs to output the specific dir for each dep, and electron-builder should directly use the dep's dir instead of concatenating.

[mmaietta]

Makes sense. Sounds like a breaking change for app-builder, so I'll prob need to get write access to the project first. Looks like it could also use some changeset/changelog+CI+publishing automation as well

[beyondkmp]

The merging process of app-builder-bin is too slow, so I directly forked a version called app-builder-precompiled-bin and updated it in this MR(beyondkmp#2). I also made modifications to the electron-builder code. You can check it out when you have time

[mmaietta]

I actually just got write-access to app-builder, just working on getting the right permissions to do CI/versioning/release automation now.

Nice work! Can you open up a PR from that branch to this repo? (with the new dependency) Curious how all the CI tests play out.

---

Update: Release automation is set up, now testing PR changes with v5.0.0-alpha.0. Now just need to get any of your changes pushed there and I can handle the rest here

[beyondkmp]

Nice work! Can you open up a PR from that branch to this repo? (with the new dependency) Curious how all the CI tests play out.

I'm investigating the cause of the failure. It seems like some might be due to permission issues, preventing them from running.

[mmaietta]

If using pnpm to publish your binary for testing as a new dependency, you'll need to have this configuration for retaining the +x permissions on app-builder
https://github.com/develar/app-builder/blob/dc5dc6dd07cdb6528ce931bf1782cf613236f923/package.json#L30-L47

[beyondkmp]

@mmaietta The ci tests are failed because mksquashfs's format is wrong.

 cannot execute  cause=fork/exec /home/runner/.cache/electron-builder/appimage/appimage-13.0.1/linux-x64/mksquashfs: exec format error

In appimage-13.0.1, the arch of mksquashfs in linux-x64 is arm64. Please help release a new version to fix it.

➜  linux-x64 file mksquashfs
mksquashfs: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, BuildID[sha1]=7669be255e4e48f9ec78d683dcc2f1578012fc94, not stripped

[mmaietta]

So I don't control/have access to electron-builder-binaries atm, and I'm not seeing any solid guidance on the repo to contribute new binaries. I'll try and revert 13.0.1 -> 13.0.0 for AppImage in app-builder-bin package and see if that resolves the issue

[mmaietta]

Renovate bot keeps deleting the branch. Opened new PR #8139