Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update app-builder-bin to 5.0.0-alpha #8139

Closed
wants to merge 10 commits into from

Conversation

mmaietta
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Mar 18, 2024

⚠️ No Changeset found

Latest commit: 8773657

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 8773657
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/65f7dfe242d89000081bd2e2
😎 Deploy Preview https://deploy-preview-8139--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta
Copy link
Collaborator Author

@beyondkmp , mksquashfs is working now, great call on the downgrade. Back to the same dependency issue in app-builder now 🙁 .

 FAIL  src/HoistedNodeModuleTest.ts (22.464 s)
  ✕ conflict versions (4538 ms)

  ● conflict versions

    ENOENT: no such file or directory, scandir '/tmp/et-db411cd21f3bbd882f3a5a30c58db6ff/t-jNdi69/test-project-1/packages/test-app/node_modules/foo'

@beyondkmp
Copy link
Collaborator

beyondkmp commented Mar 19, 2024

@mmaietta I have fixed this in https://github.com/beyondkmp/electron-builder/actions/runs/8339546872/job/22821735838?pr=2.
image

But there are other two failed test cases, both of which are related to the native module. I'm not very familiar with this yet. This is more complicated than I thought and will take more time to figure out.

@mmaietta
Copy link
Collaborator Author

Nice work! Yeah, those are some hefty snapshots that are failing. I'll take a look at them as well and see what I can report back with

@mmaietta mmaietta closed this Apr 26, 2024
@mmaietta mmaietta deleted the app-builder-bin-5.0 branch September 24, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants