-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta] Planned changes to the manifest format #517
Comments
Not sure if manifest files should change so much in time. I wonder what is the root cause of such evolving? Is it a matter of a discussion? Also, what about existing packages (I'm asking specifically about |
The main reason for the changes are that we discussed quite a few naming changes over the last weeks in Agent / Kibana which I think should also make it into the packages to be consistent. And 7.9 is our last chance to really break things, so I rather do them all now. Happy to share more details related to each change. For the |
In elastic/package-registry#517 the naming of the file paths inside a package is standardised to only use `_` and not `-`. This adjusts the paths for `ilm-policy`, `component-template`, `index-template` to the correct path. An additional change here is to get rid of assets we don't support yet, like rollup jobs and ml jobs. We will reintroduce these when we support them.
) In elastic/package-registry#517 the naming of the file paths inside a package is standardised to only use `_` and not `-`. This adjusts the paths for `ilm-policy`, `component-template`, `index-template` to the correct path. An additional change here is to get rid of assets we don't support yet, like rollup jobs and ml jobs. We will reintroduce these when we support them.
…70600) In elastic/package-registry#517 the naming of the file paths inside a package is standardised to only use `_` and not `-`. This adjusts the paths for `ilm-policy`, `component-template`, `index-template` to the correct path. An additional change here is to get rid of assets we don't support yet, like rollup jobs and ml jobs. We will reintroduce these when we support them.
We want to move away from logs to `logfile` Reference: elastic/package-registry#517
…19761) * [Elastic Agent] Remove support for "logs" and only support logfile We want to move away from logs to `logfile` Reference: elastic/package-registry#517 * Changelog
…lastic#19761) * [Elastic Agent] Remove support for "logs" and only support logfile We want to move away from logs to `logfile` Reference: elastic/package-registry#517 * Changelog (cherry picked from commit 2682ec8)
…19761) (#19850) * [Elastic Agent] Remove support for "logs" and only support logfile We want to move away from logs to `logfile` Reference: elastic/package-registry#517 (cherry picked from commit 2682ec8)
…lastic#19761) * [Elastic Agent] Remove support for "logs" and only support logfile We want to move away from logs to `logfile` Reference: elastic/package-registry#517 * Changelog
@ycombinator @ph @mtojek I'm going to close this issue as moving forward, we can't do any breaking changes anymore to the package. |
It is already assumed that packages shouldn't contain directories with hyphens in their names. EPR is already rejecting them since elastic/package-registry#517. Add this restriction to the spec.
A few changes are planned to the manifest(s) format. This is to track these changes:
Rename
datasources
toconfig_templates
We remove the term datasources across the different components. This now also has to be removed in the packages and be renamed to config_templates:
datasources
toconfig_templates
in dataset manifest package-storage#94Cleanup terms
Cleanup terms used inside the registry.
Requirements to constraints
We currently use requirements section. To align with the agent and other parts, it should be renamed to constraints. In line with this task, also the default dependencies in the packages should be udpated.
Update categories
Directory names cleanup
Some of the directory names contained
-
, others_
. This also had an effect on how the config options are called and what paths users have to define. To only have one way, it was decided to use_
everywhere and packages need to be adjusted.-
if directory. Validate that directory does not contain - #572Ingest pipeline config option
The ingest pipeline config option should be moved under the new Elasticsearch object for consistency
elasticsearch.ingest_pipeline.name
as config option #564Rename input logs to logfile
logs
on the agent sideMore
More details to come
The text was updated successfully, but these errors were encountered: