Replace requirements by conditions #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR needs updating after elastic/package-registry#519 is merged.
ruflin
commented
Jun 30, 2020
| @@ -17,6 +17,8 @@ import ( | |||
| var zeroVersion = semver.MustParse("0.0.0") | |||
|
|
|||
| func createRequirement(kibanaContent kibanaContent, datasetContent []datasetContent) (util.Requirement, error) { | |||
| // TODO: Update requirement | |||
There was a problem hiding this comment.
@mtojek I'm thinking to make the requirement for it by default ^7.9 instead of reading it from module as none of these will work with older version then Kibana 7.9. This will also simplify the code. We can also do this in a follow up PR.
💚 Build Succeeded
Expand to view the summary
Build stats
|
29 tasks
|
Closing in favor of #149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs updating after elastic/package-registry#519 is merged.