This repository has been archived by the owner on Jan 27, 2023. It is now read-only.
Update base packages to use new paths #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in elastic/package-registry#565 the names of the directories should only use `_` and no `-`. This updates the base package to use both directories in parallel.
This was referenced Jun 29, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
mtojek
approved these changes
Jun 29, 2020
29 tasks
thomasneirynck
pushed a commit
to thomasneirynck/package-storage
that referenced
this pull request
Sep 28, 2021
) There was a mix of using package, manifest or integration for the same thing in the code because of historical reasons. This PR introduces the Package struct with multiple methods and package is now used across the code. The methods on the Package struct also simplify the implementation of the search and categories endpoint. Validation of the manifest.yml file for the version now happens when creating a package instance. This makes later checks for the version simpler and we detect issues earlier. The errors already show up on build time because of this. Some of the docs comments were cleaned up or extended for better readability of the code. Having a separate Package struct with methods also helps adding further unit tests without having to build packages. No functionality was changed in this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in elastic/package-registry#565 the names of the directories should only use
_and no-. This updates the base package to use both directories in parallel.