[ML] APM Latency Correlations #99905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
force-pushed
the
ml-apm-correlations
branch
from
81730ec to
d0028dd
Compare
walterra
force-pushed
the
ml-apm-correlations
branch
from
aab841e to
220bca7
Compare
qn895
changed the title
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
smith
approved these changes
Jun 29, 2021
qn895
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 29, 2021
* [ML] Async Search Service. * [ML] Log Log Area Charts Grid. Scatterplot with streaming data. * [ML] Remove scatterplot streaming demo. * [ML] Improved histogram bins for log scale. * [ML] Move client side code from Ml to APM plugin. * [ML] Adds correlation table. * [ML] Layout tweaks. * [ML] Move server side code from ML to APM. * [ML] Remove console.logs. * [ML] Fix types. * [ML] Chart area line type fix. Slowness %. * [ML] Comment unused vars. * Fix missing pluginsStart data in context * Add KS test value and rename table columns * Update percentiles to be correct * Make columns optional * Update fractionals/expectations to match with backend logic * Update so progress is 100% when all is completed * Make pre-processing steps smaller part of overall progress(to show charts earlier) * Add no correlations found message * Fix progress logic * Fix incorrect threshold, types * Add back APM filtering functionality to match with other table * Improve histogram equality check with random sampling * Show overall latency distribution right away * Rename demo tab to latencyCorrelationsTab * Update percentiles query to use hdr * [ML] Fix issue where apm-* might have multiple indices with different mappings where keyword is not the only type - Fix to check for keyword mapping more thoroughly - Add try catch if one of the es search fail, don't quit the entire fetch * Remove commented code * Remove kstest column, round correlation to 2 sigfig dec * Remove old latency tab, replace with ml latency correlations tab as first/default one * Set axis to start at 0 because agg may results in weird * Remove commented code for grouping duplicates * Update msg to mean significant correlations * Add i18n * Change correlations flyout back to medium size * Add name of service or transaction for clarity * Share i18n * Consolidate roundToDecimalPlace usage * Remove redundant isDuplicate * Create MAX_CORRELATIONS_TO_SHOW * Update mlCorrelationcolumns * Fix i18n quotations * Update query to include filter * Revert "Update query to include filter" This reverts commit 9a37eec * Rename MlCorrelations to MlLatencyCorrelations for clarity * Add pagination * Update include/exclude logic for field candidates and add ip field support * Add transactionName filter suport * Reorganize math utils * Group duplicates together * Fix typescript, better hasPrefixToInclude support check, * Remove Finished toast * Add title to y axis * Reduce number of tick labels to show * Highlight table row that is being used for graph * Add from to follow MDN guideline * Add APM style prefix * Fix i18n * [ML] Fix logic for tick format to only show power of 10 * Replace roundToDecimalPlace with asPreciseDecimal * Switch to lodash range * Clean up get_query_with_params * Prioritize candidates using field_terms * Update percentiles result type to be array instead of objects * Use observability's rangeQuery instead * Change arg format of query * Revert candidate_terms logic * Consolidate fractions, expectations, and ranges calc * Add tooltip for Correlation * Change terms size to 20 * Move env/service/transaction sticky header to top level, remove link * Add support for http.response.status_code * Replace histogram circular markers with bars * Delete unused roundToDecimalPlace * Add fractions calculation * Make notes of fractions and fix bucket correlation * Remove any, commented code, consolidate cancelFetch * Use es6 max * Align tooltip at the top * Get rid of getCoreServices, param docs, rename type, remove rangeQuery * Adjust range * Show all values without grouping duplicates * Fix pagination * Make flyout larger Co-authored-by: Quynh Nguyen <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 29, 2021
* [ML] Async Search Service. * [ML] Log Log Area Charts Grid. Scatterplot with streaming data. * [ML] Remove scatterplot streaming demo. * [ML] Improved histogram bins for log scale. * [ML] Move client side code from Ml to APM plugin. * [ML] Adds correlation table. * [ML] Layout tweaks. * [ML] Move server side code from ML to APM. * [ML] Remove console.logs. * [ML] Fix types. * [ML] Chart area line type fix. Slowness %. * [ML] Comment unused vars. * Fix missing pluginsStart data in context * Add KS test value and rename table columns * Update percentiles to be correct * Make columns optional * Update fractionals/expectations to match with backend logic * Update so progress is 100% when all is completed * Make pre-processing steps smaller part of overall progress(to show charts earlier) * Add no correlations found message * Fix progress logic * Fix incorrect threshold, types * Add back APM filtering functionality to match with other table * Improve histogram equality check with random sampling * Show overall latency distribution right away * Rename demo tab to latencyCorrelationsTab * Update percentiles query to use hdr * [ML] Fix issue where apm-* might have multiple indices with different mappings where keyword is not the only type - Fix to check for keyword mapping more thoroughly - Add try catch if one of the es search fail, don't quit the entire fetch * Remove commented code * Remove kstest column, round correlation to 2 sigfig dec * Remove old latency tab, replace with ml latency correlations tab as first/default one * Set axis to start at 0 because agg may results in weird * Remove commented code for grouping duplicates * Update msg to mean significant correlations * Add i18n * Change correlations flyout back to medium size * Add name of service or transaction for clarity * Share i18n * Consolidate roundToDecimalPlace usage * Remove redundant isDuplicate * Create MAX_CORRELATIONS_TO_SHOW * Update mlCorrelationcolumns * Fix i18n quotations * Update query to include filter * Revert "Update query to include filter" This reverts commit 9a37eec * Rename MlCorrelations to MlLatencyCorrelations for clarity * Add pagination * Update include/exclude logic for field candidates and add ip field support * Add transactionName filter suport * Reorganize math utils * Group duplicates together * Fix typescript, better hasPrefixToInclude support check, * Remove Finished toast * Add title to y axis * Reduce number of tick labels to show * Highlight table row that is being used for graph * Add from to follow MDN guideline * Add APM style prefix * Fix i18n * [ML] Fix logic for tick format to only show power of 10 * Replace roundToDecimalPlace with asPreciseDecimal * Switch to lodash range * Clean up get_query_with_params * Prioritize candidates using field_terms * Update percentiles result type to be array instead of objects * Use observability's rangeQuery instead * Change arg format of query * Revert candidate_terms logic * Consolidate fractions, expectations, and ranges calc * Add tooltip for Correlation * Change terms size to 20 * Move env/service/transaction sticky header to top level, remove link * Add support for http.response.status_code * Replace histogram circular markers with bars * Delete unused roundToDecimalPlace * Add fractions calculation * Make notes of fractions and fix bucket correlation * Remove any, commented code, consolidate cancelFetch * Use es6 max * Align tooltip at the top * Get rid of getCoreServices, param docs, rename type, remove rangeQuery * Adjust range * Show all values without grouping duplicates * Fix pagination * Make flyout larger Co-authored-by: Quynh Nguyen <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Walter Rafelsberger <[email protected]> Co-authored-by: Quynh Nguyen <[email protected]>
1 task
1 task
This was referenced Jul 8, 2021
Closed
3 tasks
24 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the previous latency tab with a new
Latency correlationstab with the main goal to help profiling a set of transactions, and to understand which transaction field values are mainly responsible for slow transactions. A different type of statistical analysis is used for this workflow:Screen.Recording.2021-06-28.at.16.27.50.mov
Related issues:
Checklist
Delete any items that are not applicable to this PR.