Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix APM latency order of sticky header properties, add help popover #103759

Merged
merged 14 commits into from
Jul 13, 2021
Merged

[ML] Fix APM latency order of sticky header properties, add help popover #103759

merged 14 commits into from
Jul 13, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 29, 2021 •
edited
Loading

Summary

Related to #99905

This PR fixes #104185. The updated order for the flyout header properties is now Service name | Environment | Transaction name
Screen Shot 2021-07-01 at 15 15 38

This PR adds an EuiPopover similar to how they were added in Lens and contains content similar to what was originally written in the Kibana guide.

image

It also addresses feedback about the text in the tooltip:

image

@lcawl lcawl added :ml apm:correlations release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.14.0 v8.0.0 labels Jun 29, 2021
@lcawl lcawl mentioned this pull request Jun 29, 2021
Closed
@lcawl lcawl marked this pull request as ready for review June 29, 2021 19:54
@lcawl lcawl requested a review from a team as a code owner June 29, 2021 19:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@lcawl lcawl requested a review from qn895 June 29, 2021 19:55
@lcawl lcawl mentioned this pull request Jun 29, 2021
Closed
@lcawl
Copy link
Contributor Author

lcawl commented Jun 30, 2021

@elasticmachine run elasticsearch-ci/docs

@spalger spalger added v7.15.0 and removed v7.14.0 labels Jun 30, 2021
@qn895 qn895 self-assigned this Jul 1, 2021
@qn895 qn895 changed the title [ML] APM latency correlations help popover [ML] Fix APM latency order of sticky header properties, add help popover Jul 1, 2021
sorenlouv
sorenlouv approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

stevedodson
stevedodson suggested changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@stevedodson stevedodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

@qn895 qn895 mentioned this pull request Jul 8, 2021
Closed
@lcawl lcawl mentioned this pull request Jul 9, 2021
Merged
@lcawl
Copy link
Contributor Author

lcawl commented Jul 9, 2021

@elasticmachine merge upstream

stevedodson
stevedodson suggested changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@stevedodson stevedodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes

peteharverson
peteharverson requested changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed an issue with the internationalization of the icon used to launch the help popover - would you be able to include the fix in this PR?

x-pack/plugins/apm/public/components/app/help_popover/help_popover.tsx Outdated Show resolved Hide resolved
@lcawl lcawl requested a review from a team as a code owner July 9, 2021 16:18
peteharverson
peteharverson approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl
Copy link
Contributor Author

lcawl commented Jul 13, 2021

@elasticmachine merge upstream

@lcawl lcawl added the v7.14.0 label Jul 13, 2021
@lcawl lcawl enabled auto-merge (squash) July 13, 2021 15:59
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1566 1568 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +3.2KB
ml 5.9MB 5.9MB +118.0B
total +3.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@lcawl lcawl disabled auto-merge July 13, 2021 16:56
@peteharverson peteharverson merged commit bd2e4e3 into elastic:master Jul 13, 2021
@lcawl lcawl deleted the apm-popover branch July 13, 2021 16:59
lcawl added a commit to lcawl/kibana that referenced this pull request Jul 13, 2021
@lcawl @qn895 @kibanamachine
[ML] Fix APM latency order of sticky header properties, add help popo…
48c04dc 
…ver (elastic#103759)

* [ML] APM latency correlations help popover

* Remove spacer

* [ML] Updates correlation tooltip

* Remove scss, use styled popover instead

* Fix order to be Service > Environment > Transaction

* Addresses popover text feedback

* Addresses more popover text feedback

* Adds performance warning to popover; improves tooltip

* Internationalizes aria label in popover

* Internationalizes aria label in ML popover

Co-authored-by: Quynh Nguyen <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@lcawl lcawl mentioned this pull request Jul 13, 2021
Merged
lcawl added a commit to lcawl/kibana that referenced this pull request Jul 13, 2021
@lcawl @qn895 @kibanamachine
[ML] Fix APM latency order of sticky header properties, add help popo…
86b6915 
…ver (elastic#103759)

* [ML] APM latency correlations help popover

* Remove spacer

* [ML] Updates correlation tooltip

* Remove scss, use styled popover instead

* Fix order to be Service > Environment > Transaction

* Addresses popover text feedback

* Addresses more popover text feedback

* Adds performance warning to popover; improves tooltip

* Internationalizes aria label in popover

* Internationalizes aria label in ML popover

Co-authored-by: Quynh Nguyen <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@lcawl lcawl mentioned this pull request Jul 13, 2021
Merged
lcawl added a commit that referenced this pull request Jul 13, 2021
@lcawl @qn895 @kibanamachine
[ML] Fix APM latency order of sticky header properties, add help popo…
66bf4c0 
…ver (#103759) (#105474)

* [ML] APM latency correlations help popover

* Remove spacer

* [ML] Updates correlation tooltip

* Remove scss, use styled popover instead

* Fix order to be Service > Environment > Transaction

* Addresses popover text feedback

* Addresses more popover text feedback

* Adds performance warning to popover; improves tooltip

* Internationalizes aria label in popover

* Internationalizes aria label in ML popover

Co-authored-by: Quynh Nguyen <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Quynh Nguyen <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
lcawl added a commit that referenced this pull request Jul 13, 2021
@lcawl @qn895 @kibanamachine
[ML] Fix APM latency order of sticky header properties, add help popo…
b8ff424 
…ver (#103759) (#105473)

* [ML] APM latency correlations help popover

* Remove spacer

* [ML] Updates correlation tooltip

* Remove scss, use styled popover instead

* Fix order to be Service > Environment > Transaction

* Addresses popover text feedback

* Addresses more popover text feedback

* Adds performance warning to popover; improves tooltip

* Internationalizes aria label in popover

* Internationalizes aria label in ML popover

Co-authored-by: Quynh Nguyen <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Quynh Nguyen <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevedodson stevedodson stevedodson requested changes

@qn895 qn895 qn895 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@qn895 qn895

Labels
apm:correlations :ml release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Bug: Latency correlations: Switch environment and transaction name around in the flyout header
8 participants
@lcawl @elasticmachine @kibanamachine @sorenlouv @stevedodson @peteharverson @qn895 @spalger