Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Latency correlations: Show service name and environment as metadata in the flyout #102997

Closed
formgeist opened this issue Jun 22, 2021 · 5 comments
Assignees
Labels
apm:correlations enhancement New value added to drive a business result :ml Team:APM All issues that need APM UI Team support

Comments

@formgeist
Copy link
Contributor

formgeist commented Jun 22, 2021

Summary

Moved over from meta issue: #102499

We should reiterate the selected service and environment that is the basis for the correlation data being shown.

Currently, the selected service is shown in the latency distribution chart title, but it's a little too subtle. Also any search queries made on the originating views will be transferred into the correlations view and display like this;

screencapture-showcase-ml-qa-5602-app-apm-services-frontend-overview-2021-06-22-21_11_20

We should consider how to show the fixed query params like service name and environment while allowing space for the custom query filters.

Solution

Temporary metadata header and filters in the flyout header

image

@formgeist formgeist added Team:APM All issues that need APM UI Team support enhancement New value added to drive a business result :ml needs design apm:correlations labels Jun 22, 2021
@formgeist formgeist self-assigned this Jun 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member

qn895 commented Jun 23, 2021

@formgeist I added the table for the service name and transaction name here to match with what APM currently has for the Transaction details tab #99905 (comment). However, considering that the new correlation tab might take a bit longer to load all the correlations, having the link that go back to the main page might not be ideal. What do you think if we not hyperlink them here?

@formgeist
Copy link
Contributor Author

@qn895 Yeah, we can just remove the service name and transaction link (if that appeared). I was working on another proposal where we put that info in the flyout header instead because it will apply to both latency and error rate correlations.

The header should be able to hold both the service name, environment, and transaction name along with the filter callout for whatever query the user has applied in the search bar in the main view.

Latency correlations - Show service name and enviroment (header info + query callout)

@formgeist formgeist removed their assignment Jun 24, 2021
@qn895 qn895 self-assigned this Jul 8, 2021
@qn895
Copy link
Member

qn895 commented Jul 8, 2021

Closing via #99905 and #103759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:correlations enhancement New value added to drive a business result :ml Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

5 participants