-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Data Frame Analytics: Improved error handling for scatterplot matrix. #91993
[ML] Data Frame Analytics: Improved error handling for scatterplot matrix. #91993
Conversation
Pinging @elastic/ml-ui (:ml) |
]; | ||
|
||
const queryFallback = searchQuery !== undefined ? searchQuery : { match_all: {} }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the searchQuery passed in already be the default one when no query is set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I noticed this during updating this PR that the fallback to match_all
here is unnecessary.
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
Testing this out with a regression job on the ecommerce data set, I noticed there is an issue with the Total Feature Importance Job config is:
Raised #92181 for this issue, which is not connected to the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM.
Added a comment with an unrelated issue I found when creating a regression job with the ecommerce data set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡
…trix. (elastic#91993) Improves error handling for the scatterplot matrix. Documents with fields with arrays of values cannot be visualized in the scatterplot matrix. This adds a warning callout when the fetched data includes such documents.
* master: Ability to filter alerts by string parameters (elastic#92036) [APM] Fix for flaky correlations API test (elastic#91673) (elastic#92094) [Enterprise Search] Migrate shared role mapping components (elastic#91723) [file_upload] move ml Importer classes to file_upload plugin (elastic#91559) [Discover] Always show the "hide missing fields" toggle (elastic#91889) v2 migrations should exit process on corrupt saved object document (elastic#91465) [ML] Data Frame Analytics exploration page: filters improvements (elastic#91748) [ML] Data Frame Analytics: Improved error handling for scatterplot matrix. (elastic#91993) [coverage] speed up merging results of functional tests (elastic#92111) Adds a Reason indicator to the onClose handler in AddAlert and EditAlert (elastic#92149)
…trix. (elastic#91993) Improves error handling for the scatterplot matrix. Documents with fields with arrays of values cannot be visualized in the scatterplot matrix. This adds a warning callout when the fetched data includes such documents.
…trix. (#91993) (#92203) Improves error handling for the scatterplot matrix. Documents with fields with arrays of values cannot be visualized in the scatterplot matrix. This adds a warning callout when the fetched data includes such documents. Co-authored-by: Walter Rafelsberger <[email protected]>
Summary
Part of #84420.
Fixes #91001.
Improves error handling for the scatterplot matrix. Documents with fields with arrays of values cannot be visualized in the scatterplot matrix. This adds a warning callout when the fetched data includes such documents.
Vega has some issues with field names with dots in them. By default they are treated as attributes in nested objects. There are workarounds for escaping dots but this doesn't seemed to be picked up in the case of the scatterplot matrix where the field names are part of the
row/columns
configuration. To work around this issue, we now replace dots in field names with a different but similar UTF-8 character so Vega won't treat it as a dot. The only drawback I could think of is that if a user wanted to copy/paste a field value that would include the wrong UTF-8 character, but since the visualization is rendered as a bitmap within a canvas element text cannot be copied from the visualization anyway.Checklist
Delete any items that are not applicable to this PR.
Unit or functional tests were updated or added to match the most common scenariosWorking on updated functional tests in [ML] Functional Tests: Extend canvas assertion options. #91473For maintainers