[Discover] Always show the "hide missing fields" toggle #91889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wylieconlon
added
Feature:Discover
wylieconlon
requested review from
kertal,
timroes,
flash1293,
majagrubic and
a team
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
31 tasks
flash1293
approved these changes
Feb 19, 2021
|
@elasticmachine merge upstream |
|
@wylieconlon anything blocking us to merge this? |
💛 Build succeeded, but was flaky
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kertal
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
LGTM, only thing when testing it that came to my mind, if we shouldn't change the default of hide missing fields to off in the near future. Since we now do multi field grouping .keywordetc. fields are not part of the top level list. ... or even better, align to the Lens pattern of Available fields, Empty fields, Meta fields :)
|
@kertal Want to open an issue for doing that in a future minor? |
@wylieconlon done #92208 👍 |
This was referenced Feb 22, 2021
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
Feb 22, 2021
Co-authored-by: Kibana Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 22, 2021
* master: Ability to filter alerts by string parameters (elastic#92036) [APM] Fix for flaky correlations API test (elastic#91673) (elastic#92094) [Enterprise Search] Migrate shared role mapping components (elastic#91723) [file_upload] move ml Importer classes to file_upload plugin (elastic#91559) [Discover] Always show the "hide missing fields" toggle (elastic#91889) v2 migrations should exit process on corrupt saved object document (elastic#91465) [ML] Data Frame Analytics exploration page: filters improvements (elastic#91748) [ML] Data Frame Analytics: Improved error handling for scatterplot matrix. (elastic#91993) [coverage] speed up merging results of functional tests (elastic#92111) Adds a Reason indicator to the onClose handler in AddAlert and EditAlert (elastic#92149)
wylieconlon
pushed a commit
that referenced
this pull request
Feb 22, 2021
) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
wylieconlon
pushed a commit
that referenced
this pull request
Feb 22, 2021
) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior will change soon, but as of the time this PR was introduced there are two behaviors:
Fixes #91876
Checklist