-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Functional Tests: Extend canvas assertion options. #91473
Conversation
Pinging @elastic/ml-ui (:ml) |
@elasticmachine merge upstream |
@darnautov @peteharverson yay, this passed finally, ready for review :) |
{ key: '#DDDDDD', value: 3 }, | ||
// line | ||
{ key: '#6092C0', value: 1 }, | ||
{ key: '#DDDDDD', value: 48 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running locally on Windows, I had to edit these values to the following to get it to pass:
// tick/grid/axis
{ key: '#DDDDDD', value: 50 },
// lines
{ key: '#98A2B3', value: 30 },
{ key: '#6092C0', value: 10 },
{ key: '#5F92C0', value: 6 },
Before that, this single test was failing with the error
retry.tryForTime timeout: Error: Color stats for 'mlDFAnalyticsClassificationExplorationRocCurveChart' should be w
ithin tolerance. Expected: '[{"key":"#DDDDDD","value":48},{"key":"#98A2B3","value":32},{"key":"#6092C0","value":10},{"ke
y":"#5F92C0","value":6}]' (got '[{"key":"#DDDDDD","value":54.5920820644334,"withinTolerance":false},{"key":"#98A2B3","va
lue":26.106747876262215,"withinTolerance":false},{"key":"#6092C0","value":9.145696425709247,"withinTolerance":true},{"ke
y":"#5F92C0","value":9.145696425709247,"withinTolerance":true}]')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated in b70f3f9, let's see if it's within the tolerance to still pass CI :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and LGTM
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
Yay, flaky test runner passed 42x without failures. https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1384/ |
Updates the canvas element assertion service and stabilizes tests. # Conflicts: # x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation.ts
Updates the canvas element assertion service and stabilizes tests.
Summary
Fixes #91450.
Fixes #94854.
Updates the canvas element assertion service:
isColorWithinTolerance()
now exposed as part of the canvas element service to make it available for single color checks.These options in combination should make assertions more stable.
Checklist
For maintainers