fix adding Visualize visualization to dashboard from modal directs user to dashboard listing page #90090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
added
regression
v8.0.0
Team:AppServices
release_note:skip
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
ThomThomson
approved these changes
Feb 3, 2021
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Feb 3, 2021
…er to dashboard listing page (elastic#90090)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #89917
Regression was introduced in #87635
In #87635 I needed additional methods on
kbnUrlStateStorageand decided to completely expose underlyingurlControlsand removed previously exposedcancelandflushmethods fromkbnUrlStateStorageI missed that state syncing utils were calling
cancelwhen stoping state syncing: https://github.com/elastic/kibana/blob/master/src/plugins/kibana_utils/public/state_sync/state_sync.ts#L161Calling this
cancelwas canceling any pending state updates which is important for #87635 scenario.This pr returns
cancelonkbnUrlStateStorageremoved in #87635 and fixes #89917Will be covered by functional test in #89245
Checklist
Delete any items that are not applicable to this PR.
For maintainers