Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Time to Visualize] Add functional tests for adding visualizations from Visualize, Lens, and Maps and adjust capabilities for new modal #89245

Merged
merged 26 commits into from
Feb 10, 2021
Merged

[Time to Visualize] Add functional tests for adding visualizations from Visualize, Lens, and Maps and adjust capabilities for new modal #89245

merged 26 commits into from
Feb 10, 2021

Conversation

poffdeluxe
Copy link
Contributor

@poffdeluxe poffdeluxe commented Jan 25, 2021 •
edited
Loading

Summary

Adds the following functional tests for Visualize, Lens, and Maps:

  • Add new metric to new dashboard
  • Add existing metric to new dashboard (saves as new)
  • Add new metric to existing dashboard
  • Add existing metric to existing dashboard (saves as new)
  • Add a test for lens to verify the proper options are showing based on user capabilities

@poffdeluxe poffdeluxe added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. v7.12.0 labels Jan 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

@ThomThomson ThomThomson mentioned this pull request Jan 28, 2021
Closed
33 tasks
@poffdeluxe poffdeluxe requested a review from a team as a code owner January 29, 2021 17:27
@poffdeluxe poffdeluxe changed the title [Time to Visualize] Add functional tests for adding visualizations from Visualize and Lens using new modal [Time to Visualize] Add functional tests for adding visualizations from Visualize, Lens, and Maps using new modal Jan 29, 2021
@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

thomasneirynck
thomasneirynck approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maps/** lgtm, thx!

@poffdeluxe poffdeluxe mentioned this pull request Feb 1, 2021
Closed
@Dosant Dosant mentioned this pull request Feb 2, 2021
Merged
2 tasks
@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

@poffdeluxe poffdeluxe requested a review from a team February 4, 2021 18:55
@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented Feb 4, 2021

jenkins test this

@poffdeluxe poffdeluxe requested a review from a team February 5, 2021 01:52
ThomThomson
ThomThomson approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This is a very thorough suite of tests. The permission change, you could potentially do in this PR as well - or save it for a followup.

x-pack/test/functional/apps/lens/add_to_dashboard.ts
const panelCount = await PageObjects.dashboard.getPanelCount();
expect(panelCount).to.eql(1);

await PageObjects.timeToVisualize.resetNewDashboard();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution, I'll make sure to edit some of the Lens tests to use this soon.

x-pack/test/functional/apps/lens/add_to_dashboard.ts Outdated Show resolved Hide resolved
@poffdeluxe poffdeluxe changed the title [Time to Visualize] Add functional tests for adding visualizations from Visualize, Lens, and Maps using new modal [Time to Visualize] Add functional tests for adding visualizations from Visualize, Lens, and Maps and adjust capabilities for new modal Feb 8, 2021
@poffdeluxe poffdeluxe requested a review from flash1293 February 9, 2021 16:44
@flash1293
Copy link
Contributor

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualize 98.8KB 98.9KB +51.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
presentationUtil 25.9KB 25.6KB -303.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@poffdeluxe poffdeluxe merged commit 4ee5f09 into elastic:master Feb 10, 2021
@poffdeluxe poffdeluxe deleted the test/add-to-dashboard-modal-actual branch February 10, 2021 18:48
This was referenced Feb 10, 2021
Merged
Closed
poffdeluxe added a commit that referenced this pull request Feb 10, 2021
@poffdeluxe @kibanamachine
[Time to Visualize] Add functional tests for adding visualizations fr…
97a83fb 
…om Visualize, Lens, and Maps and adjust capabilities for new modal (#89245) (#91004)

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@poffdeluxe @elasticmachine @kibanamachine @spalger @flash1293 @thomasneirynck @ThomThomson