-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lens "Add to dashboard" is appearing for underprivileged users #88719
Comments
Pinging @elastic/kibana-presentation (Team:Presentation) |
I spoke with @ryankeairns today about what the fix for this should look like. If the user is missing create new dashboard privileges, don't show the add to new dashboard option. If the user is missing edit privileges, don't show the add to existing dashboard option. If the user is neither or doesn't not have any dashboard access, then don't show the "add to dashboard" options and default to add to library. I'm going to wait to fix this until @clintandrewhall's PR here is merged: #88112 |
@poffdeluxe will maps be impacted by this once #88759 is merged? Will maps have to do anything or will |
Removing Lens tag as this looks like a general issue. Please add back if I'm mistaken |
@nreese Apologies for the late reply here but the modal will handle it internally. @clintandrewhall's PR here includes a first pass at handling some of the privileges. So, all that being said, no changes will have to be made specifically to maps. |
Fixed as a small part of #88112 |
With a test for it here: #89245 |
🎉 Thanks, team! |
Kibana version: 7.11
Describe the bug:
Lens has a new "Save to dashboard" feature, which allows a Lens user to save their visualization within either a new or existing dashboard.
This display of this feature is not respecting the current user's privileges, so it give users an option that will ultimately fail.
Steps to reproduce:
All
access to Visualize, but no access to DashboardsSave
.Expected behavior:
A user without write access to Dashboards should not be given the option to create/modify them via this save dialog
Screenshots (if relevant):
The text was updated successfully, but these errors were encountered: