[Maps] allow saving maps to dashboards #88759

nreese · 2021-01-19T21:07:47Z

This PR adds support for SavedObjectSaveModalDashboard so when users save a new map they are presented with the option to save the map directly to a dashboard.

elasticmachine · 2021-01-19T21:07:49Z

Pinging @elastic/kibana-gis (Team:Geo)

…oard

afharo

Core changes (x-pack/test/saved_object_tagging/functional/tests/maps_integration.ts) LGTM!

x-pack/test/saved_object_tagging/functional/tests/maps_integration.ts

x-pack/plugins/maps/public/routes/map_page/saved_map/saved_map.ts

kindsun · 2021-01-21T18:46:25Z

Nice PR! Seems to work well overall. A few flow-related questions. Not sure how much control we have over these pieces but I'll still float them:

Why is the only option for saving on the dashboard option Save and go to Dashboard? Shouldn't a user be able to save it to a dashboard without redirecting? It's a pretty normal workflow to save your map periodically as you construct it without wanting to navigate away from the Maps app. If you save it to your library, it appears you can't save it to a dashboard after that which makes it feel kind of "all or nothing" on the first save.
Can we change the default in the pop-up to No dasboard, but add to library?
Related to the last question, should we minimally change the default radio button selected depending on whether a user has any existing dashboards?

nreese · 2021-01-21T18:58:55Z

@elasticmachine merge upstream

nreese · 2021-01-21T19:09:04Z

Why is the only option for saving on the dashboard option Save and go to Dashboard? Shouldn't a user be able to save it to a dashboard without redirecting? It's a pretty normal workflow to save your map periodically as you construct it without wanting to navigate away from the Maps app. If you save it to your library, it appears you can't save it to a dashboard after that which makes it feel kind of "all or nothing" on the first save.
Can we change the default in the pop-up to No dasboard, but add to library?
Related to the last question, should we minimally change the default radio button selected depending on whether a user has any existing dashboards?

These are all great questions. Maybe @poffdeluxe can answer them. I think these need to be addressed from a Kibana standpoint and not uniquely in Maps. I am trying to make Maps as consistent with Lens as possible with regards to global chrome and dashboard works flows. The reason is that any differences between UIs take users out of their muscle memory flow and causes them to stutter/pause/think. A great tool is one that blurs into the background. UI differences shatter this blurring.

kindsun · 2021-01-21T21:24:18Z

These are all great questions. Maybe @poffdeluxe can answer them. I think these need to be addressed from a Kibana standpoint and not uniquely in Maps. I am trying to make Maps as consistent with Lens as possible with regards to global chrome and dashboard works flows. The reason is that any differences between UIs take users out of their muscle memory flow and causes them to stutter/pause/think. A great tool is one that blurs into the background. UI differences shatter this blurring.

I'm all for consistency between apps, just so long as there's some clear plan to update the common component or allow customization of it so that it works as expected across apps with differing needs. No real objections to the updates on our end, just unsure if we should move forward with merging with the component as is. I guess I'll also be interested in what @poffdeluxe has to say.

One other odd feature is you can't save a new Map based on an old one in a different way. For example you can't:

create a map
save it to your library
then either modify it or not and try to re-save it to a dashboard

The options stay greyed out and force you to save it the way the previous map was saved:

nreese · 2021-01-21T21:34:14Z

then either modify it or not and try to re-save it to a dashboard. The options stay greyed out and force you to save it the way the previous map was saved

Unchecking "Save as new map" will enable the "Add to dashboard" section.

kindsun · 2021-01-21T21:38:16Z

Unchecking "Save as new map" will enable the "Add to dashboard" section.

Ah good catch, that's good then. Still a bummer we can't change how it's saved (why are library and dashboard mutually exclusive?) but I already mentioned that in the first bullet in #88759 (comment)

nickpeihl

lgtm!

tested in firefox.

I think the Save to Dashboard workflow is fine, because it redirects to a dashboard in a dirty state (unsaved). The user is required to consciously save the changes to the dashboard.

thomasneirynck

Agreed with @aaronjcaldwell comments, but in +1 because it's consistent with the rest of Kibana.

Having to check an additional radio-button is also a price payed only once, at the firsti save. If the map is saved-to-library, it will automatically continue to do that.

nreese · 2021-01-26T00:04:20Z

@elasticmachine merge upstream

kmartastic · 2021-01-26T00:36:20Z

My 2 cents. I support the consistency in Kibana when creating new visualizations/maps.

Shouldn't a user be able to save it to a dashboard without redirecting? It's a pretty normal workflow to save your map periodically as you construct it without wanting to navigate away from the Maps app.

This is a good comment ^

The UX forces the user into one of two paths. If the user knows they want to build a dashboard, this is fine.
If a user wants to build a map... and the flexibility to add the map to a dashboard later, without the content management overhead, they cannot. That's not ideal. If this was a change in behavior from a previous version, it would be a problem.

We should not choose consistency without fully understanding the impact of that choice on real flows. This PR doesn't impede the customer, this PR improves and encourages the dashboard first flow, but it might annoy customers down the road when they want to clean up their library / manage their content.

kibanamachine · 2021-01-26T01:59:45Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 14b6632

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`maps`	2.6MB	2.6MB	+1021.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`maps`	138.3KB	138.5KB	+243.0B

History

💚 Build #100424 succeeded d2180c3
💛 Build #100419 was flaky b82b674
💚 Build #100173 succeeded bc2bdcd
💔 Build #100020 failed ccd994b
💔 Build #99766 failed b11930b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [Maps] allow saving maps to dashboards * update saveMap functional test method * update tags functional test * review feedback Co-authored-by: Kibana Machine <[email protected]>

* [Maps] allow saving maps to dashboards * update saveMap functional test method * update tags functional test * review feedback Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

[Maps] allow saving maps to dashboards

b11930b

nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.12.0 labels Jan 19, 2021

nreese requested a review from thomasneirynck January 19, 2021 21:07

nreese requested a review from poffdeluxe January 19, 2021 21:09

nreese added 2 commits January 20, 2021 06:35

Merge branch 'master' of github.com:elastic/kibana into save_to_dashb…

24553c4

…oard

update saveMap functional test method

ccd994b

nreese requested review from a team as code owners January 20, 2021 14:46

afharo approved these changes Jan 20, 2021

View reviewed changes

update tags functional test

bc2bdcd

nreese mentioned this pull request Jan 20, 2021

Lens "Add to dashboard" is appearing for underprivileged users #88719

Closed

kindsun reviewed Jan 21, 2021

View reviewed changes

x-pack/test/saved_object_tagging/functional/tests/maps_integration.ts Show resolved Hide resolved

kindsun reviewed Jan 21, 2021

View reviewed changes

x-pack/plugins/maps/public/routes/map_page/saved_map/saved_map.ts Outdated Show resolved Hide resolved

Merge branch 'master' into save_to_dashboard

b82b674

review feedback

d2180c3

nreese requested a review from kindsun January 21, 2021 19:11

nickpeihl approved these changes Jan 21, 2021

View reviewed changes

thomasneirynck reviewed Jan 25, 2021

View reviewed changes

Merge branch 'master' into save_to_dashboard

14b6632

nreese merged commit 3938fa6 into elastic:master Jan 26, 2021

nreese mentioned this pull request Jan 26, 2021

[7.x] [Maps] allow saving maps to dashboards (#88759) #89332

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] allow saving maps to dashboards #88759

[Maps] allow saving maps to dashboards #88759

nreese commented Jan 19, 2021

elasticmachine commented Jan 19, 2021

afharo left a comment

kindsun commented Jan 21, 2021 •

edited

Loading

nreese commented Jan 21, 2021

nreese commented Jan 21, 2021

kindsun commented Jan 21, 2021

nreese commented Jan 21, 2021

kindsun commented Jan 21, 2021

nickpeihl left a comment

thomasneirynck left a comment •

edited

Loading

nreese commented Jan 26, 2021

kmartastic commented Jan 26, 2021

kibanamachine commented Jan 26, 2021

[Maps] allow saving maps to dashboards #88759

[Maps] allow saving maps to dashboards #88759

Conversation

nreese commented Jan 19, 2021

elasticmachine commented Jan 19, 2021

afharo left a comment

Choose a reason for hiding this comment

kindsun commented Jan 21, 2021 • edited Loading

nreese commented Jan 21, 2021

nreese commented Jan 21, 2021

kindsun commented Jan 21, 2021

nreese commented Jan 21, 2021

kindsun commented Jan 21, 2021

nickpeihl left a comment

Choose a reason for hiding this comment

thomasneirynck left a comment • edited Loading

Choose a reason for hiding this comment

nreese commented Jan 26, 2021

kmartastic commented Jan 26, 2021

kibanamachine commented Jan 26, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

kindsun commented Jan 21, 2021 •

edited

Loading

thomasneirynck left a comment •

edited

Loading