-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] EMS baselayer should load cleanly #88531
[Maps] EMS baselayer should load cleanly #88531
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
x-pack/plugins/maps/public/classes/layers/vector_tile_layer/vector_tile_layer.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/classes/layers/vector_tile_layer/vector_tile_layer.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
tested in Chrome
x-pack/plugins/maps/public/classes/layers/vector_tile_layer/vector_tile_layer.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for fixing this
code review
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Summary
Closes #88515
This bug was "revealed" by #87310.
vector_tile_layer
was loading the EMS-meta twice in short succession due to not correctly setting the metadata of the request. This did not cause end-user errors, just a double refresh cycle internally.By introducing #87310, the second refresh would throw an error, causing the layer-error to show up in the TOC.
The fix is that
vector_tile_layer
should correctly set the metadata about the request. This way, thecanSkip
logic behaves as expected and there is no 2nd redundant refresh.Checklist
Delete any items that are not applicable to this PR.
For maintainers