[Enterprise Search] Miscellaneous test cleanups (#88525)

* Update older tests mocking useValues to setMockValues

* Update older logic tests to use newer LogicMounter helper

- NOTE: shared logic files are still using resetContext however, in order to not accidentally override/mock kea + since they should be testing their own mount helpers

* Merge/DRY kea.mock helpers into a single import

* Remove unnecessary kea.mock file imports

- the automock already happens when you import something from the kea.mock file
- in some cases in WS the mock just wasn't needed

* Newline linting

- Do I need a hobby? yes
- Is this my hobby? ...maybe

Co-authored-by: Kibana Machine <[email protected]>

x-pack/plugins/enterprise_search/public/applications/app_search/app_logic.test.ts

@@ -4,15 +4,16 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { resetContext } from 'kea';
+import { LogicMounter } from '../__mocks__';
 
 import { DEFAULT_INITIAL_APP_DATA } from '../../../common/__mocks__';
 import { AppLogic } from './app_logic';
 
 describe('AppLogic', () => {
+  const { mount } = new LogicMounter(AppLogic);
+
   beforeEach(() => {
-    resetContext({});
-    AppLogic.mount();
+    mount();
   });
 
   const DEFAULT_VALUES = {

x-pack/plugins/enterprise_search/public/applications/app_search/components/credentials/credentials_flyout/form_components/key_engine_access.test.tsx

@@ -4,8 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { setMockValues, setMockActions } from '../../../../../__mocks__/kea.mock';
-import { rerender } from '../../../../../__mocks__';
+import { setMockValues, setMockActions, rerender } from '../../../../../__mocks__';
 
 import React from 'react';
 import { shallow } from 'enzyme';

x-pack/plugins/enterprise_search/public/applications/app_search/components/document_creation/creation_mode_components/paste_json_text.test.tsx

@@ -4,8 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { setMockValues, setMockActions } from '../../../../__mocks__/kea.mock';
-import { rerender } from '../../../../__mocks__';
+import { setMockValues, setMockActions, rerender } from '../../../../__mocks__';
 
 import React from 'react';
 import { shallow } from 'enzyme';

x-pack/plugins/enterprise_search/public/applications/app_search/components/document_creation/creation_mode_components/upload_json_file.test.tsx

@@ -4,8 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { setMockValues, setMockActions } from '../../../../__mocks__/kea.mock';
-import { rerender } from '../../../../__mocks__';
+import { setMockValues, setMockActions, rerender } from '../../../../__mocks__';
 
 import React from 'react';
 import { shallow } from 'enzyme';

x-pack/plugins/enterprise_search/public/applications/app_search/components/documents/document_detail.test.tsx

@@ -3,8 +3,9 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
-import { setMockValues, setMockActions } from '../../../__mocks__/kea.mock';
+
 import '../../../__mocks__/react_router_history.mock';
+import { setMockValues, setMockActions } from '../../../__mocks__/kea.mock';
 import { unmountHandler } from '../../../__mocks__/shallow_useeffect.mock';
 
 import React from 'react';

x-pack/plugins/enterprise_search/public/applications/app_search/components/documents/documents.test.tsx

@@ -3,6 +3,7 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
+
 import { setMockValues } from '../../../__mocks__/kea.mock';
 
 import React from 'react';

x-pack/plugins/enterprise_search/public/applications/app_search/components/documents/search_experience/search_experience.test.tsx

@@ -3,9 +3,9 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
-import '../../../../__mocks__/kea.mock';
-import { setMockValues } from '../../../../__mocks__';
+
 import '../../../../__mocks__/enterprise_search_url.mock';
+import { setMockValues } from '../../../../__mocks__';
 
 const mockSetFields = jest.fn();
 

x-pack/plugins/enterprise_search/public/applications/app_search/components/documents/search_experience/views/paging_view.test.tsx

@@ -3,6 +3,7 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
+
 import React from 'react';
 
 import { shallow } from 'enzyme';

x-pack/plugins/enterprise_search/public/applications/app_search/components/documents/search_experience/views/results_per_page_view.test.tsx

@@ -3,6 +3,7 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
+
 import React from 'react';
 
 import { shallow } from 'enzyme';

x-pack/plugins/enterprise_search/public/applications/app_search/components/engine/engine_nav.test.tsx

@@ -4,8 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { setMockValues } from '../../../__mocks__/kea.mock';
-import { rerender } from '../../../__mocks__';
+import { setMockValues, rerender } from '../../../__mocks__';
 
 import React from 'react';
 import { shallow } from 'enzyme';

x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/engines_overview.test.tsx

@@ -5,8 +5,7 @@
  */
 
 import '../../../__mocks__/shallow_useeffect.mock';
-import { rerender } from '../../../__mocks__';
-import { setMockValues, setMockActions } from '../../../__mocks__/kea.mock';
+import { setMockValues, setMockActions, rerender } from '../../../__mocks__';
 
 import React from 'react';
 import { shallow, ShallowWrapper } from 'enzyme';

x-pack/plugins/enterprise_search/public/applications/app_search/components/result/result.test.tsx

@@ -5,7 +5,6 @@
  */
 
 import React from 'react';
-
 import { shallow, ShallowWrapper } from 'enzyme';
 import { EuiPanel } from '@elastic/eui';
 

x-pack/plugins/enterprise_search/public/applications/app_search/components/result/result_field.test.tsx

@@ -5,7 +5,6 @@
  */
 
 import React from 'react';
-
 import { shallow } from 'enzyme';
 
 import { ResultField } from './result_field';

x-pack/plugins/enterprise_search/public/applications/app_search/components/result/result_header.test.tsx

@@ -5,7 +5,6 @@
  */
 
 import React from 'react';
-
 import { shallow } from 'enzyme';
 
 import { ResultHeader } from './result_header';

x-pack/plugins/enterprise_search/public/applications/app_search/components/result/result_header_item.test.tsx

@@ -5,7 +5,6 @@
  */
 
 import React from 'react';
-
 import { mount } from 'enzyme';
 
 import { ResultHeaderItem } from './result_header_item';

x-pack/plugins/enterprise_search/public/applications/app_search/components/settings/log_retention/log_retention_confirmation_modal.test.tsx

@@ -4,7 +4,6 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import '../../../../__mocks__/kea.mock';
 import { setMockActions, setMockValues } from '../../../../__mocks__';
 
 import React from 'react';

x-pack/plugins/enterprise_search/public/applications/app_search/components/settings/log_retention/log_retention_panel.test.tsx

@@ -4,9 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import '../../../../__mocks__/kea.mock';
 import '../../../../__mocks__/shallow_useeffect.mock';
-
 import { setMockActions, setMockValues } from '../../../../__mocks__';
 
 import React from 'react';

x-pack/plugins/enterprise_search/public/applications/app_search/components/settings/settings.test.tsx

@@ -3,6 +3,7 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
+
 import React from 'react';
 import { shallow } from 'enzyme';
 import { EuiPageContentBody } from '@elastic/eui';

x-pack/plugins/enterprise_search/public/applications/app_search/index.test.tsx

@@ -5,7 +5,6 @@
  */
 
 import '../__mocks__/shallow_useeffect.mock';
-import '../__mocks__/kea.mock';
 import '../__mocks__/enterprise_search_url.mock';
 import { setMockValues, setMockActions } from '../__mocks__';
 

x-pack/plugins/enterprise_search/public/applications/enterprise_search/components/product_card/product_card.test.tsx

@@ -4,11 +4,9 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import '../../../__mocks__/kea.mock';
-import { mockTelemetryActions } from '../../../__mocks__';
+import { setMockValues, mockTelemetryActions } from '../../../__mocks__';
 
 import React from 'react';
-import { useValues } from 'kea';
 import { shallow } from 'enzyme';
 
 import { EuiCard } from '@elastic/eui';
@@ -59,7 +57,7 @@ describe('ProductCard', () => {
   });
 
   it('renders correct button text when host not present', () => {
-    (useValues as jest.Mock).mockImplementation(() => ({ config: { host: '' } }));
+    setMockValues({ config: { host: '' } });
 
     const wrapper = shallow(<ProductCard product={WORKPLACE_SEARCH_PLUGIN} image="ws.jpg" />);
     const card = wrapper.find(EuiCard).dive().shallow();

x-pack/plugins/enterprise_search/public/applications/enterprise_search/index.test.tsx

@@ -7,8 +7,7 @@
 import React from 'react';
 import { shallow } from 'enzyme';
 
-import { setMockValues } from '../__mocks__/kea.mock';
-import { rerender } from '../__mocks__';
+import { setMockValues, rerender } from '../__mocks__';
 
 import { EnterpriseSearch } from './';
 import { SetupGuide } from './components/setup_guide';

x-pack/plugins/enterprise_search/public/applications/shared/indexing_status/indexing_status.test.tsx

@@ -4,9 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import '../../__mocks__/kea.mock';
 import '../../__mocks__/shallow_useeffect.mock';
-
 import { setMockActions, setMockValues } from '../../__mocks__';
 
 import React from 'react';

x-pack/plugins/enterprise_search/public/applications/shared/kibana_chrome/generate_breadcrumbs.test.ts

@@ -4,8 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { setMockValues } from '../../__mocks__/kea.mock';
-import { mockKibanaValues, mockHistory } from '../../__mocks__';
+import { setMockValues, mockKibanaValues, mockHistory } from '../../__mocks__';
 
 jest.mock('../react_router_helpers', () => ({
   letBrowserHandleEvent: jest.fn(() => false),

x-pack/plugins/enterprise_search/public/applications/shared/kibana_chrome/set_chrome.test.tsx

@@ -5,8 +5,7 @@
  */
 
 import '../../__mocks__/shallow_useeffect.mock';
-import { setMockValues } from '../../__mocks__/kea.mock';
-import { mockKibanaValues, mockHistory } from '../../__mocks__';
+import { setMockValues, mockKibanaValues, mockHistory } from '../../__mocks__';
 
 import React from 'react';
 import { shallow } from 'enzyme';

x-pack/plugins/enterprise_search/public/applications/shared/not_found/not_found.test.tsx

@@ -4,10 +4,9 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import '../../__mocks__/kea.mock';
+import { setMockValues } from '../../__mocks__/kea.mock';
 
 import React from 'react';
-import { useValues } from 'kea';
 import { shallow } from 'enzyme';
 
 import { EuiButton as EuiButtonExternal, EuiEmptyPrompt } from '@elastic/eui';
@@ -45,7 +44,7 @@ describe('NotFound', () => {
   });
 
   it('changes the support URL if the user has a gold+ license', () => {
-    (useValues as jest.Mock).mockReturnValueOnce({ hasGoldLicense: true });
+    setMockValues({ hasGoldLicense: true });
     const wrapper = shallow(<NotFound product={APP_SEARCH_PLUGIN} />);
     const prompt = wrapper.find(EuiEmptyPrompt).dive().shallow();
 

x-pack/plugins/enterprise_search/public/applications/shared/setup_guide/setup_guide.test.tsx

@@ -4,8 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { setMockValues } from '../../__mocks__/kea.mock';
-import { rerender } from '../../__mocks__';
+import { setMockValues, rerender } from '../../__mocks__';
 
 import React from 'react';
 import { shallow, ShallowWrapper } from 'enzyme';

x-pack/plugins/enterprise_search/public/applications/workplace_search/app_logic.test.ts

@@ -4,15 +4,16 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { resetContext } from 'kea';
+import { LogicMounter } from '../__mocks__';
 
 import { DEFAULT_INITIAL_APP_DATA } from '../../../common/__mocks__';
 import { AppLogic } from './app_logic';
 
 describe('AppLogic', () => {
+  const { mount } = new LogicMounter(AppLogic);
+
   beforeEach(() => {
-    resetContext({});
-    AppLogic.mount();
+    mount();
   });
 
   const DEFAULT_VALUES = {

x-pack/plugins/enterprise_search/public/applications/workplace_search/index.test.tsx

@@ -5,7 +5,6 @@
  */
 
 import '../__mocks__/shallow_useeffect.mock';
-import '../__mocks__/kea.mock';
 import { setMockValues, setMockActions, mockKibanaValues } from '../__mocks__';
 
 import React from 'react';

x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/add_source/add_source_list.test.tsx

@@ -4,9 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import '../../../../../__mocks__/kea.mock';
 import '../../../../../__mocks__/shallow_useeffect.mock';
-
 import { setMockActions, setMockValues } from '../../../../../__mocks__';
 import {
   contentSources,

x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/add_source/add_source_logic.test.ts

@@ -4,9 +4,8 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { resetContext } from 'kea';
-
 import {
+  LogicMounter,
   mockFlashMessageHelpers,
   mockHttpValues,
   expectedAsyncError,
@@ -30,6 +29,7 @@ import {
 } from './add_source_logic';
 
 describe('AddSourceLogic', () => {
+  const { mount } = new LogicMounter(AddSourceLogic);
   const { http } = mockHttpValues;
   const { clearFlashMessages, flashAPIErrors } = mockFlashMessageHelpers;
 
@@ -71,8 +71,7 @@ describe('AddSourceLogic', () => {
 
   beforeEach(() => {
     jest.clearAllMocks();
-    resetContext({});
-    AddSourceLogic.mount();
+    mount();
   });
 
   it('has expected default values', () => {

x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/add_source/available_sources_list.test.tsx

@@ -4,9 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import '../../../../../__mocks__/kea.mock';
 import '../../../../../__mocks__/shallow_useeffect.mock';
-
 import { setMockValues } from '../../../../../__mocks__';
 
 import { mergedAvailableSources } from '../../../../__mocks__/content_sources.mock';

x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/add_source/configure_custom.test.tsx

@@ -4,9 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import '../../../../../__mocks__/kea.mock';
 import '../../../../../__mocks__/shallow_useeffect.mock';
-
 import { setMockActions, setMockValues } from '../../../../../__mocks__';
 
 import React from 'react';

x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/add_source/configure_oauth.test.tsx

@@ -4,9 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import '../../../../../__mocks__/kea.mock';
 import '../../../../../__mocks__/shallow_useeffect.mock';
-
 import { setMockActions, setMockValues } from '../../../../../__mocks__';
 
 import React from 'react';

x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/add_source/connect_instance.test.tsx

@@ -4,9 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import '../../../../../__mocks__/kea.mock';
 import '../../../../../__mocks__/shallow_useeffect.mock';
-
 import { setMockActions, setMockValues } from '../../../../../__mocks__';
 
 import React from 'react';

x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/components/add_source/re_authenticate.test.tsx

@@ -4,9 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import '../../../../../__mocks__/kea.mock';
 import '../../../../../__mocks__/shallow_useeffect.mock';
-
 import { setMockActions, setMockValues } from '../../../../../__mocks__';
 
 import React from 'react';