[APM] add sanitize_field_names & transaction_ignore_urls vars to Node.js agent remote config

[trentm]

Summary

This adds the Node.js agent to the include list for two APM agent central config vars:

• sanitize_field_names: see [META 319] Align sanitize_field_names option + central config apm-agent-nodejs#1811
• transaction_ignore_urls: see Implement transaction_ignore_urls apm-agent-nodejs#1689

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately

Kibana unit tests

Running the relevant test file passed:

[x-pack]% node scripts/jest.js plugins/apm/common/agent_configuration/setting_definitions/index.test.ts
Running Jest with --config /Users/trentm/tm/kibana/x-pack/jest.config.js
jest-haste-map: duplicate manual mock found: index
  The following files share their name; please delete one of them:
    * <rootDir>/x-pack/plugins/enterprise_search/server/__mocks__/index.ts
    * <rootDir>/x-pack/plugins/enterprise_search/common/__mocks__/index.ts
...
jest-haste-map: duplicate manual mock found: index
  The following files share their name; please delete one of them:
    * <rootDir>/x-pack/plugins/security_solution/public/common/lib/kibana/__mocks__/index.ts
    * <rootDir>/x-pack/plugins/security_solution/public/overview/components/events_by_dataset/__mocks__/index.tsx

  PASS  plugins/apm/common/agent_configuration/setting_definitions/index.test.ts
  filterByAgent
    when `excludeAgents` is dotnet and nodejs
      ✓ should not include dotnet (1 ms)
      ✓ should include go
    when `includeAgents` is dotnet and nodejs
      ✓ should not include go (1 ms)
      ✓ should include dotnet (1 ms)
    options per agent
      ✓ go (1 ms)
      ✓ java (1 ms)
      ✓ js-base
      ✓ rum-js
      ✓ nodejs
      ✓ python
      ✓ dotnet (1 ms)
      ✓ ruby (1 ms)
      ✓ "All" services (no agent name) (1 ms)
  settingDefinitions
    ✓ should have correct default values (5 ms)

Test Suites: 1 passed, 1 total
Tests:       14 passed, 14 total
Snapshots:   1 passed, 1 total
Time:        2.239 s, estimated 3 s
Ran all test suites matching /plugins\/apm\/common\/agent_configuration\/setting_definitions\/index.test.ts/i.

End to end test

Creating an Agent settings configuration now includes those two vars as expected:

I was able to observe my running play "esapp" updating its log level to "trace" (required to see the following log output):

% node esapp.js
...
Remote config failure. Unsupported config names: sanitize_field_names
Remote config success. Updated captureBody: off
Remote config success. Updated logLevel: trace
Remote config success. Updated transactionIgnoreUrls: /ping,/metrics,/ol*
Remote config success. Updated transactionSampleRate: 1
Remote config success. Updated transactionIgnoreUrlRegExp: /^\/ping$/i,/^\/metrics$/i,/^\/ol.*$/i
...

The "Unsupported config names: sanitize_field_names" is because that is coming in elastic/apm-agent-nodejs#1898 (currently in code review).
/cc @astorm

[elasticmachine]

Pinging @elastic/apm-ui (Team:apm)

[smith]

@trentm looks like Jest failed because of a timeout. I can tell it to retest.

[smith]

retest

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: b67799c

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
apm	5.4MB	5.4MB	+18.0B

Distributable file count

id	before	after	diff
default	46985	47745	+760

History

• 💔 Build #93696 failed b67799c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[trentm]

looks like Jest failed because of a timeout. I can tell it to retest.

Thanks, @smith!