Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] add sanitize_field_names & transaction_ignore_urls vars to Node.js agent remote config #85655

Merged
merged 2 commits into from
Dec 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ export const generalSettings: RawSettingDefinition[] = [
'Sometimes it is necessary to sanitize, i.e., remove, sensitive data sent to Elastic APM. This config accepts a list of wildcard patterns of field names which should be sanitized. These apply to HTTP headers (including cookies) and `application/x-www-form-urlencoded` data (POST form fields). The query string and the captured request body (such as `application/json` data) will not get sanitized.',
}
),
includeAgents: ['java', 'python', 'go', 'dotnet'],
includeAgents: ['java', 'python', 'go', 'dotnet', 'nodejs'],
},

// Ignore transactions based on URLs
Expand All @@ -254,6 +254,6 @@ export const generalSettings: RawSettingDefinition[] = [
'Used to restrict requests to certain URLs from being instrumented. This config accepts a comma-separated list of wildcard patterns of URL paths that should be ignored. When an incoming HTTP request is detected, its request path will be tested against each element in this list. For example, adding `/home/index` to this list would match and remove instrumentation from `http://localhost/home/index` as well as `http://whatever.com/home/index?value1=123`',
}
),
includeAgents: ['java'],
includeAgents: ['java', 'nodejs'],
},
];
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ describe('filterByAgent', () => {
expect(getSettingKeysForAgent('nodejs')).toEqual([
'capture_body',
'log_level',
'sanitize_field_names',
'transaction_ignore_urls',
'transaction_max_spans',
'transaction_sample_rate',
]);
Expand Down