Skip to content

Commit

Permalink
[APM] add sanitize_field_names & transaction_ignore_urls vars to Node…
Browse files Browse the repository at this point in the history
….js agent remote config (elastic#85655)
  • Loading branch information
trentm committed Dec 14, 2020
1 parent 43af154 commit 1f62491
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ export const generalSettings: RawSettingDefinition[] = [
'Sometimes it is necessary to sanitize, i.e., remove, sensitive data sent to Elastic APM. This config accepts a list of wildcard patterns of field names which should be sanitized. These apply to HTTP headers (including cookies) and `application/x-www-form-urlencoded` data (POST form fields). The query string and the captured request body (such as `application/json` data) will not get sanitized.',
}
),
includeAgents: ['java', 'python', 'go', 'dotnet'],
includeAgents: ['java', 'python', 'go', 'dotnet', 'nodejs'],
},

// Ignore transactions based on URLs
Expand All @@ -254,6 +254,6 @@ export const generalSettings: RawSettingDefinition[] = [
'Used to restrict requests to certain URLs from being instrumented. This config accepts a comma-separated list of wildcard patterns of URL paths that should be ignored. When an incoming HTTP request is detected, its request path will be tested against each element in this list. For example, adding `/home/index` to this list would match and remove instrumentation from `http://localhost/home/index` as well as `http://whatever.com/home/index?value1=123`',
}
),
includeAgents: ['java'],
includeAgents: ['java', 'nodejs'],
},
];
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ describe('filterByAgent', () => {
expect(getSettingKeysForAgent('nodejs')).toEqual([
'capture_body',
'log_level',
'sanitize_field_names',
'transaction_ignore_urls',
'transaction_max_spans',
'transaction_sample_rate',
]);
Expand Down

0 comments on commit 1f62491

Please sign in to comment.