[SECURITY SOLUTIONS] Keep context of timeline when switching tabs in security solutions #82237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_timeline_in_redux
…_timeline_in_redux
…_timeline_in_redux_2
XavierM
added
bug
x-pack/plugins/security_solution/public/timelines/containers/index.test.tsx
Show resolved
Hide resolved
…_timeline_in_redux_2
XavierM
force-pushed
the
keep_state_of_timeline_in_redux_2
branch
3 times, most recently
from
62138c3 to
b97fde3
Compare
XavierM
force-pushed
the
keep_state_of_timeline_in_redux_2
branch
from
b97fde3 to
91ef942
Compare
x-pack/plugins/security_solution/public/common/components/search_bar/index.tsx
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/common/components/super_date_picker/index.tsx
Outdated
Show resolved
Hide resolved
…_timeline_in_redux_2
andrew-goldstein
approved these changes
Nov 5, 2020
There was a problem hiding this comment.
Thanks @XavierM for tenaciously pursuing a fix for this, and patiently working through all the permutations 🙏
Desk tested locally throughout the app
LGTM 🚀
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Nov 6, 2020
…security solutions (elastic#82237) * try to keep timeline context when switching tabs * fix popover * simpler solution to keep timelien context between tabs * fix timeline context with relative date * allow update on the kql bar when opening new timeline * keep detail view in context when savedObjectId of the timeline does not chnage * remove redux solution and just KISS it * add unit test for the popover * add test on timeline context cache * final commit -> to fix context of timeline between tabs * keep timerange kind to absolute when refreshing * fix bug today/thiw week to be absolute and not relative * add unit test for absolute date for today and this week * fix absolute today/this week on timeline * fix refresh between page and timeline when link * clean up * remove nit Co-authored-by: Patryk Kopycinski <[email protected]>
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Nov 6, 2020
…security solutions (elastic#82237) * try to keep timeline context when switching tabs * fix popover * simpler solution to keep timelien context between tabs * fix timeline context with relative date * allow update on the kql bar when opening new timeline * keep detail view in context when savedObjectId of the timeline does not chnage * remove redux solution and just KISS it * add unit test for the popover * add test on timeline context cache * final commit -> to fix context of timeline between tabs * keep timerange kind to absolute when refreshing * fix bug today/thiw week to be absolute and not relative * add unit test for absolute date for today and this week * fix absolute today/this week on timeline * fix refresh between page and timeline when link * clean up * remove nit Co-authored-by: Patryk Kopycinski <[email protected]>
XavierM
added a commit
that referenced
this pull request
Nov 6, 2020
…security solutions (#82237) (#82793) * try to keep timeline context when switching tabs * fix popover * simpler solution to keep timelien context between tabs * fix timeline context with relative date * allow update on the kql bar when opening new timeline * keep detail view in context when savedObjectId of the timeline does not chnage * remove redux solution and just KISS it * add unit test for the popover * add test on timeline context cache * final commit -> to fix context of timeline between tabs * keep timerange kind to absolute when refreshing * fix bug today/thiw week to be absolute and not relative * add unit test for absolute date for today and this week * fix absolute today/this week on timeline * fix refresh between page and timeline when link * clean up * remove nit Co-authored-by: Patryk Kopycinski <[email protected]> Co-authored-by: Patryk Kopycinski <[email protected]>
XavierM
added a commit
that referenced
this pull request
Nov 9, 2020
…abs in security solutions (#82237) (#82794) * [SECURITY SOLUTIONS] Keep context of timeline when switching tabs in security solutions (#82237) * try to keep timeline context when switching tabs * fix popover * simpler solution to keep timelien context between tabs * fix timeline context with relative date * allow update on the kql bar when opening new timeline * keep detail view in context when savedObjectId of the timeline does not chnage * remove redux solution and just KISS it * add unit test for the popover * add test on timeline context cache * final commit -> to fix context of timeline between tabs * keep timerange kind to absolute when refreshing * fix bug today/thiw week to be absolute and not relative * add unit test for absolute date for today and this week * fix absolute today/this week on timeline * fix refresh between page and timeline when link * clean up * remove nit Co-authored-by: Patryk Kopycinski <[email protected]> * increase limits Co-authored-by: Patryk Kopycinski <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is related to this issue #81833 with the caveat that I am not able to fix all the issues at once since the main problem is about how we are bootstrapping our different tabs as a sub plugin to have the kibana menu on the left. So we won't be able to close the issue for 7.10, but we will give at least a better experience for the end user
So this PR will eliminate these:
but I was not able to keep the scroll position of the table the same.
We also add a small bug on the popover on the network page
Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking API changes and was labeled appropriately