-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SECURITY SOLUTIONS] Keep context of timeline when switching tabs in security solutions #82150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
bug
Fixes for quality problems that affect the customer experience
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
impact:critical
This issue should be addressed immediately due to a critical level of impact on the product.
v7.10.0
Team:Threat Hunting
Security Solution Threat Hunting Team
Feature:Timeline
Security Solution Timeline feature
labels
Oct 30, 2020
…_timeline_in_redux
💔 Build Failed
Failed CI Steps
Test Failurespersist the deletion of a column.persistent timeline persist the deletion of a columnStack Trace
Chrome UI Functional Tests.test/functional/apps/discover/_doc_table·ts.discover app discover doc table add and remove columns should remove columns from the tableStandard Out
Stack Trace
Chrome UI Functional Tests.test/functional/apps/getting_started/_shakespeare·js.Getting Started Shakespeare should configure Terms aggregation on play_nameStandard Out
Stack Trace
and 11 more failures, only showing the first 3. Metrics [docs]@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
We simplify the PR to this one -> #82237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Timeline
Security Solution Timeline feature
impact:critical
This issue should be addressed immediately due to a critical level of impact on the product.
release_note:skip
Skip the PR/issue when compiling release notes
Team:Threat Hunting
Security Solution Threat Hunting Team
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is related to this issue #81833 with the caveat that I am not able to fix all the issues at once since the main problem is about how we are bootstrapping our different tabs as a sub plugin to have the kibana menu on the left. So we won't be able to close the issue for 7.10, but we will give at least a better experience for the end user
So this PR will eliminate these:
but I was not able to keep the scroll position of the table the same.