Merge branch 'master' of github.com:elastic/kibana into keep_state_of…

…_timeline_in_redux_2

.github/ISSUE_TEMPLATE/v8_breaking_change.md

@@ -13,7 +13,7 @@ assignees: ''
 ****************************************
  
 Please add a "NeededFor:${TeamName}" label to denote the team that is
-requesting the breaking change is surfaced in the Upgrade Assistant.
+requesting the breaking change to be surfaced in the Upgrade Assistant.
  
 -->
 
@@ -27,21 +27,24 @@ requesting the breaking change is surfaced in the Upgrade Assistant.
 
 **How many users will be affected?**
 
-<!-- e.g., Based on telemetry data, roughly 75% of our users will need to make changes to x -->
-<!-- e.g., A majority of users will need to make changes to x. -->
+<!-- e.g. Based on telemetry data, roughly 75% of our users will need to make changes to x. -->
+<!-- e.g. A majority of users will need to make changes to x. -->
 
 **What can users do to address the change manually?**
 
-<!-- If applicable, describe the manual workaround -->
+<!-- If applicable, describe the manual migration steps and/or link to available docs. -->
 
 **How could we make migration easier with the Upgrade Assistant?**
 
+<!-- This can be as basic as notifying the user about the deprecation and linking to some
+  migration docs, or as advanced as a dedicated UI for fixing the problem. -->
+
 **Are there any edge cases?**
 
 ## Test Data
 
-Provide test data. We can’t build a solution without data to test it against.
+<!-- Provide test data. We can’t build a solution without data to test it against. -->
 
 ## Cross links
 
-Cross-link to relevant [Elasticsearch breaking changes](https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-8.0.html).
+<!-- Provide context. Cross-link to relevant [Elasticsearch breaking changes](https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-8.0.html), PRs that introduced the breaking change, or other related issues. -->

docs/api/spaces-management/get_all.asciidoc

@@ -11,14 +11,38 @@ experimental[] Retrieve all {kib} spaces.
 
 `GET <kibana host>:<port>/api/spaces/space`
 
+[[spaces-api-get-all-query-params]]
+==== Query parameters
+
+`purpose`::
+  (Optional, string) Valid options include `any`, `copySavedObjectsIntoSpace`, and `shareSavedObjectsIntoSpace`. This determines what
+  authorization checks are applied to the API call. If `purpose` is not provided in the URL, the `any` purpose is used.
+
+`include_authorized_purposes`::
+  (Optional, boolean) When enabled, the API will return any spaces that the user is authorized to access in any capacity, and each space
+  will contain the purpose(s) for which the user is authorized. This can be useful to determine which spaces a user can read but not take a
+  specific action in. If the Security plugin is not enabled, this will have no effect, as no authorization checks would take place.
++
+NOTE: This option cannot be used in conjunction with `purpose`.
+
 [[spaces-api-get-all-response-codes]]
 ==== Response code
 
 `200`::
   Indicates a successful call.
 
 [[spaces-api-get-all-example]]
-==== Example
+==== Examples
+
+[[spaces-api-get-all-example-1]]
+===== Default options
+
+Retrieve all spaces without specifying any options:
+
+[source,sh]
+--------------------------------------------------
+$ curl -X GET api/spaces/space
+--------------------------------------------------
 
 The API returns the following:
 
@@ -51,3 +75,63 @@ The API returns the following:
   }
 ]
 --------------------------------------------------
+
+[[spaces-api-get-all-example-2]]
+===== Custom options
+
+The user has read-only access to the Sales space. Retrieve all spaces and specify options:
+
+[source,sh]
+--------------------------------------------------
+$ curl -X GET api/spaces/space?purpose=shareSavedObjectsIntoSpace&include_authorized_purposes=true
+--------------------------------------------------
+
+The API returns the following:
+
+[source,sh]
+--------------------------------------------------
+[
+  {
+    "id": "default",
+    "name": "Default",
+    "description" : "This is the Default Space",
+    "disabledFeatures": [],
+    "imageUrl": "",
+    "_reserved": true,
+    "authorizedPurposes": {
+      "any": true,
+      "copySavedObjectsIntoSpace": true,
+      "findSavedObjects": true,
+      "shareSavedObjectsIntoSpace": true,
+    }
+  },
+  {
+    "id": "marketing",
+    "name": "Marketing",
+    "description" : "This is the Marketing Space",
+    "color": "#aabbcc",
+    "disabledFeatures": ["apm"],
+    "initials": "MK",
+    "imageUrl": "data:image/png;base64,iVBORw0KGgoAAAANSU",
+    "authorizedPurposes": {
+      "any": true,
+      "copySavedObjectsIntoSpace": true,
+      "findSavedObjects": true,
+      "shareSavedObjectsIntoSpace": true,
+    }
+  },
+  {
+    "id": "sales",
+    "name": "Sales",
+    "initials": "MK",
+    "disabledFeatures": ["discover", "timelion"],
+    "imageUrl": "",
+    "authorizedPurposes": {
+      "any": true,
+      "copySavedObjectsIntoSpace": false,
+      "findSavedObjects": true,
+      "shareSavedObjectsIntoSpace": false,
+    }
+  }
+]
+--------------------------------------------------

docs/developer/best-practices/typescript.asciidoc

@@ -32,7 +32,7 @@ Run `node scripts/find_plugins_without_ts_refs.js --id your_plugin_id` to get a
 
 [discrete]
 ==== Implementation
-- Make sure all the plugins listed as dependencies in `kibana.json` file have migrated to TS project references.
+- Make sure all the plugins listed as dependencies in *requiredPlugins*, *optionalPlugins* & *requiredBundles* properties of `kibana.json` manifest file have migrated to TS project references.
 - Add `tsconfig.json` in the root folder of your plugin.
 [source,json]
 ----

docs/developer/plugin-list.asciidoc

@@ -128,8 +128,8 @@ in Kibana, e.g. visualizations. It has the form of a flyout panel.
 |Utilities for building Kibana plugins.
 
 
-|{kib-repo}blob/{branch}/src/plugins/legacy_export[legacyExport]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/src/plugins/legacy_export/README.md[legacyExport]
+|The legacyExport plugin adds support for the legacy saved objects export format.
 
 
 |{kib-repo}blob/{branch}/src/plugins/management/README.md[management]
@@ -156,12 +156,12 @@ Content is fetched from the remote (https://feeds.elastic.co and https://feeds-s
 |Create choropleth maps. Display the results of a term-aggregation as e.g. countries, zip-codes, states.
 
 
-|{kib-repo}blob/{branch}/src/plugins/saved_objects[savedObjects]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/src/plugins/saved_objects/README.md[savedObjects]
+|The savedObjects plugin exposes utilities to manipulate saved objects on the client side.
 
 
-|{kib-repo}blob/{branch}/src/plugins/saved_objects_management[savedObjectsManagement]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/src/plugins/saved_objects_management/README.md[savedObjectsManagement]
+|The savedObjectsManagement plugin manages the Saved Objects management section.
 
 
 |{kib-repo}blob/{branch}/src/plugins/saved_objects_tagging_oss/README.md[savedObjectsTaggingOss]
@@ -309,8 +309,8 @@ Failure to have auth enabled in Kibana will make for a broken UI. UI-based error
 |Experimental Feature
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/cloud[cloud]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/x-pack/plugins/cloud/README.md[cloud]
+|The cloud plugin adds cloud specific features to Kibana.
 
 
 |{kib-repo}blob/{branch}/x-pack/plugins/code[code]
@@ -361,8 +361,8 @@ occuring in Kibana, initially just for the Make It Action project - alerts
 and actions.
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/features[features]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/x-pack/plugins/features/README.md[features]
+|The features plugin enhance Kibana with a per-feature privilege system.
 
 
 |{kib-repo}blob/{branch}/x-pack/plugins/file_upload/README.md[fileUpload]
@@ -378,8 +378,8 @@ or dashboards from the Kibana instance, from both server and client-side plugins
 |The GlobalSearchBar plugin provides a search interface for navigating Kibana. (It is the UI to the GlobalSearch plugin.)
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/global_search_providers[globalSearchProviders]
-|WARNING: Missing README.
+|{kib-repo}blob/{branch}/x-pack/plugins/global_search_providers/README.md[globalSearchProviders]
+|The globalSearchProviders plugin provides Kibana default search providers for the GlobalSearch plugin.
 
 
 |{kib-repo}blob/{branch}/x-pack/plugins/graph/README.md[graph]

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.ikibanasearchresponse.md

@@ -18,6 +18,6 @@ export interface IKibanaSearchResponse<RawResponse = any>
 |  [isPartial](./kibana-plugin-plugins-data-public.ikibanasearchresponse.ispartial.md) | <code>boolean</code> | Indicates whether the results returned are complete or partial |
 |  [isRunning](./kibana-plugin-plugins-data-public.ikibanasearchresponse.isrunning.md) | <code>boolean</code> | Indicates whether search is still in flight |
 |  [loaded](./kibana-plugin-plugins-data-public.ikibanasearchresponse.loaded.md) | <code>number</code> | If relevant to the search strategy, return a loaded number that represents how progress is indicated. |
-|  [rawResponse](./kibana-plugin-plugins-data-public.ikibanasearchresponse.rawresponse.md) | <code>RawResponse</code> |  |
+|  [rawResponse](./kibana-plugin-plugins-data-public.ikibanasearchresponse.rawresponse.md) | <code>RawResponse</code> | The raw response returned by the internal search method (usually the raw ES response) |
 |  [total](./kibana-plugin-plugins-data-public.ikibanasearchresponse.total.md) | <code>number</code> | If relevant to the search strategy, return a total number that represents how progress is indicated. |
 

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.ikibanasearchresponse.rawresponse.md

@@ -4,6 +4,8 @@
 
 ## IKibanaSearchResponse.rawResponse property
 
+The raw response returned by the internal search method (usually the raw ES response)
+
 <b>Signature:</b>
 
 ```typescript

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md

@@ -159,7 +159,6 @@
 |  [IndexPatternsContract](./kibana-plugin-plugins-data-public.indexpatternscontract.md) |  |
 |  [IndexPatternSelectProps](./kibana-plugin-plugins-data-public.indexpatternselectprops.md) |  |
 |  [InputTimeRange](./kibana-plugin-plugins-data-public.inputtimerange.md) |  |
-|  [ISearch](./kibana-plugin-plugins-data-public.isearch.md) |  |
 |  [ISearchGeneric](./kibana-plugin-plugins-data-public.isearchgeneric.md) |  |
 |  [ISearchSource](./kibana-plugin-plugins-data-public.isearchsource.md) | search source interface |
 |  [MatchAllFilter](./kibana-plugin-plugins-data-public.matchallfilter.md) |  |

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchinterceptor.search.md

@@ -23,5 +23,5 @@ search(request: IKibanaSearchRequest, options?: ISearchOptions): Observable<IKib
 
 `Observable<IKibanaSearchResponse>`
 
-`Observalbe` emitting the search response or an error.
+`Observable` emitting the search response or an error.
 

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchsource.md

@@ -42,7 +42,7 @@ export declare class SearchSource
 |  [getSerializedFields()](./kibana-plugin-plugins-data-public.searchsource.getserializedfields.md) |  | serializes search source fields (which can later be passed to [ISearchStartSearchSource](./kibana-plugin-plugins-data-public.isearchstartsearchsource.md)<!-- -->) |
 |  [onRequestStart(handler)](./kibana-plugin-plugins-data-public.searchsource.onrequeststart.md) |  | Add a handler that will be notified whenever requests start |
 |  [serialize()](./kibana-plugin-plugins-data-public.searchsource.serialize.md) |  | Serializes the instance to a JSON string and a set of referenced objects. Use this method to get a representation of the search source which can be stored in a saved object.<!-- -->The references returned by this function can be mixed with other references in the same object, however make sure there are no name-collisions. The references will be named <code>kibanaSavedObjectMeta.searchSourceJSON.index</code> and <code>kibanaSavedObjectMeta.searchSourceJSON.filter[&lt;number&gt;].meta.index</code>.<!-- -->Using <code>createSearchSource</code>, the instance can be re-created. |
-|  [setField(field, value)](./kibana-plugin-plugins-data-public.searchsource.setfield.md) |  | sets value to a single search source feild |
+|  [setField(field, value)](./kibana-plugin-plugins-data-public.searchsource.setfield.md) |  | sets value to a single search source field |
 |  [setFields(newFields)](./kibana-plugin-plugins-data-public.searchsource.setfields.md) |  | Internal, do not use. Overrides all search source fields with the new field array. |
 |  [setParent(parent, options)](./kibana-plugin-plugins-data-public.searchsource.setparent.md) |  | Set a searchSource that this source should inherit from |
 |  [setPreferredSearchStrategyId(searchStrategyId)](./kibana-plugin-plugins-data-public.searchsource.setpreferredsearchstrategyid.md) |  | internal, dont use |

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchsource.serialize.md

@@ -15,13 +15,13 @@ Using `createSearchSource`<!-- -->, the instance can be re-created.
 ```typescript
 serialize(): {
         searchSourceJSON: string;
-        references: import("../../../../../core/types").SavedObjectReference[];
+        references: import("src/core/server").SavedObjectReference[];
     };
 ```
 <b>Returns:</b>
 
 `{
         searchSourceJSON: string;
-        references: import("../../../../../core/types").SavedObjectReference[];
+        references: import("src/core/server").SavedObjectReference[];
     }`
 

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchsource.setfield.md

@@ -4,7 +4,7 @@
 
 ## SearchSource.setField() method
 
-sets value to a single search source feild
+sets value to a single search source field
 
 <b>Signature:</b>
 

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.isearchstart.search.md → docs/development/plugins/data/server/kibana-plugin-plugins-data-server.isearchstart.asscoped.md

@@ -1,11 +1,11 @@
 <!-- Do not edit this file. It is automatically generated by API Documenter. -->
 
-[Home](./index.md) &gt; [kibana-plugin-plugins-data-server](./kibana-plugin-plugins-data-server.md) &gt; [ISearchStart](./kibana-plugin-plugins-data-server.isearchstart.md) &gt; [search](./kibana-plugin-plugins-data-server.isearchstart.search.md)
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-server](./kibana-plugin-plugins-data-server.md) &gt; [ISearchStart](./kibana-plugin-plugins-data-server.isearchstart.md) &gt; [asScoped](./kibana-plugin-plugins-data-server.isearchstart.asscoped.md)
 
-## ISearchStart.search property
+## ISearchStart.asScoped property
 
 <b>Signature:</b>
 
 ```typescript
-search: ISearchStrategy['search'];
+asScoped: (request: KibanaRequest) => ISearchClient;
 ```

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.isearchstart.getsearchstrategy.md

@@ -4,10 +4,10 @@
 
 ## ISearchStart.getSearchStrategy property
 
-Get other registered search strategies. For example, if a new strategy needs to use the already-registered ES search strategy, it can use this function to accomplish that.
+Get other registered search strategies by name (or, by default, the Elasticsearch strategy). For example, if a new strategy needs to use the already-registered ES search strategy, it can use this function to accomplish that.
 
 <b>Signature:</b>
 
 ```typescript
-getSearchStrategy: (name: string) => ISearchStrategy<SearchStrategyRequest, SearchStrategyResponse>;
+getSearchStrategy: (name?: string) => ISearchStrategy<SearchStrategyRequest, SearchStrategyResponse>;
 ```

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.isearchstart.md

@@ -15,7 +15,7 @@ export interface ISearchStart<SearchStrategyRequest extends IKibanaSearchRequest
 |  Property | Type | Description |
 |  --- | --- | --- |
 |  [aggs](./kibana-plugin-plugins-data-server.isearchstart.aggs.md) | <code>AggsStart</code> |  |
-|  [getSearchStrategy](./kibana-plugin-plugins-data-server.isearchstart.getsearchstrategy.md) | <code>(name: string) =&gt; ISearchStrategy&lt;SearchStrategyRequest, SearchStrategyResponse&gt;</code> | Get other registered search strategies. For example, if a new strategy needs to use the already-registered ES search strategy, it can use this function to accomplish that. |
-|  [search](./kibana-plugin-plugins-data-server.isearchstart.search.md) | <code>ISearchStrategy['search']</code> |  |
+|  [asScoped](./kibana-plugin-plugins-data-server.isearchstart.asscoped.md) | <code>(request: KibanaRequest) =&gt; ISearchClient</code> |  |
+|  [getSearchStrategy](./kibana-plugin-plugins-data-server.isearchstart.getsearchstrategy.md) | <code>(name?: string) =&gt; ISearchStrategy&lt;SearchStrategyRequest, SearchStrategyResponse&gt;</code> | Get other registered search strategies by name (or, by default, the Elasticsearch strategy). For example, if a new strategy needs to use the already-registered ES search strategy, it can use this function to accomplish that. |
 |  [searchSource](./kibana-plugin-plugins-data-server.isearchstart.searchsource.md) | <code>{</code><br/><code>        asScoped: (request: KibanaRequest) =&gt; Promise&lt;ISearchStartSearchSource&gt;;</code><br/><code>    }</code> |  |
 

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.isearchstrategy.cancel.md

@@ -7,5 +7,5 @@
 <b>Signature:</b>
 
 ```typescript
-cancel?: (context: RequestHandlerContext, id: string) => Promise<void>;
+cancel?: (id: string, options: ISearchOptions, deps: SearchStrategyDependencies) => Promise<void>;
 ```

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.isearchstrategy.md

@@ -16,6 +16,6 @@ export interface ISearchStrategy<SearchStrategyRequest extends IKibanaSearchRequ
 
 |  Property | Type | Description |
 |  --- | --- | --- |
-|  [cancel](./kibana-plugin-plugins-data-server.isearchstrategy.cancel.md) | <code>(context: RequestHandlerContext, id: string) =&gt; Promise&lt;void&gt;</code> |  |
-|  [search](./kibana-plugin-plugins-data-server.isearchstrategy.search.md) | <code>(request: SearchStrategyRequest, options: ISearchOptions, context: RequestHandlerContext) =&gt; Observable&lt;SearchStrategyResponse&gt;</code> |  |
+|  [cancel](./kibana-plugin-plugins-data-server.isearchstrategy.cancel.md) | <code>(id: string, options: ISearchOptions, deps: SearchStrategyDependencies) =&gt; Promise&lt;void&gt;</code> |  |
+|  [search](./kibana-plugin-plugins-data-server.isearchstrategy.search.md) | <code>(request: SearchStrategyRequest, options: ISearchOptions, deps: SearchStrategyDependencies) =&gt; Observable&lt;SearchStrategyResponse&gt;</code> |  |
 

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.isearchstrategy.search.md

@@ -7,5 +7,5 @@
 <b>Signature:</b>
 
 ```typescript
-search: (request: SearchStrategyRequest, options: ISearchOptions, context: RequestHandlerContext) => Observable<SearchStrategyResponse>;
+search: (request: SearchStrategyRequest, options: ISearchOptions, deps: SearchStrategyDependencies) => Observable<SearchStrategyResponse>;
 ```

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.md

@@ -58,6 +58,7 @@
 |  [PluginSetup](./kibana-plugin-plugins-data-server.pluginsetup.md) |  |
 |  [PluginStart](./kibana-plugin-plugins-data-server.pluginstart.md) |  |
 |  [RefreshInterval](./kibana-plugin-plugins-data-server.refreshinterval.md) |  |
+|  [SearchStrategyDependencies](./kibana-plugin-plugins-data-server.searchstrategydependencies.md) |  |
 |  [SearchUsage](./kibana-plugin-plugins-data-server.searchusage.md) |  |
 |  [TabbedAggColumn](./kibana-plugin-plugins-data-server.tabbedaggcolumn.md) | \* |
 |  [TabbedTable](./kibana-plugin-plugins-data-server.tabbedtable.md) | \* |