[APM] Add default message to alerts. #78930

cauemarcondes · 2020-09-30T11:12:22Z

elasticmachine · 2020-09-30T11:12:27Z

Pinging @elastic/apm-ui (Team:apm)

cauemarcondes · 2020-09-30T11:14:05Z

@formgeist @bmorelli25 @sqren as suggested, I created a very basic message for each alert type available. I also added the threshold in the Transaction duration anomaly alert.

x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts

sorenlouv · 2020-09-30T11:41:31Z

We should not output ENVIRONMENT_ALL. You can use getEnvironmentLabel(environment) for this

formgeist

Overall a much-needed improvement by adding these placeholders. I wanted to ask if it's possible to detect one action from the other, and e.g. use the Subject field for the first line?

to something like

Basically, define a placeholder subject as well for the actions that use the subject field?

I think we'll make the messages more consistent across Observability in later design implementation.

x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts

sorenlouv · 2020-10-01T10:23:17Z

I wanted to ask if it's possible to detect one action from the other, and e.g. use the Subject field for the first line?
@formgeist

Alerting doesn't support default values for anything but the message field yet. But it's something @pmuellr is looking into

bmorelli25

I'm not sold on alert is firing because of the following conditions:. I think I actually like the original wording better, as I can see configuration applying to all of the bulleted values, but I can only see conditions applying to the last two. I'm not passionate about this though -- I think they're both fine. So LGTM with recommended changes.

formgeist · 2020-10-01T18:26:36Z

I'm not sold on alert is firing because of the following conditions:. I think I actually like the original wording better, as I can see configuration applying to all of the bulleted values, but I can only see conditions applying to the last two. I'm not passionate about this though -- I think they're both fine. So LGTM with recommended changes.

With many of the alerts being global, I do see service, environment and type as conditions not just configurations. Not sure if this is even something the user will notice anyhow, so happy to leave as is.

bmorelli25 · 2020-10-01T19:42:41Z

With many of the alerts being global, I do see service, environment and type as conditions not just configurations.

That's a fair point; I'm on board.

…fault-message

cauemarcondes · 2020-10-05T08:00:02Z

@elasticmachine merge upstream

sorenlouv · 2020-10-05T10:10:03Z

x-pack/plugins/apm/server/lib/alerts/action_variables.ts

+      'xpack.apm.alerts.action_variables.intervalSize',
+      {
+        defaultMessage:
+          'The interval size the alert will use to check for any incident',


If somebody doesn't understand the term "interval size" it might be a good idea to use a synonym in the description. WDYT of this?

Suggested change

'The interval size the alert will use to check for any incident',

'The length of the time period where the alert conditions were met',

or perhaps:

Suggested change

'The interval size the alert will use to check for any incident',

'The alert will trigger if the conditions are met within the given interval',

cc @bmorelli25

x-pack/plugins/apm/server/lib/alerts/action_variables.ts

x-pack/plugins/apm/server/lib/alerts/register_transaction_error_rate_alert_type.ts

x-pack/plugins/apm/common/utils/formatters/formatters.test.ts

cauemarcondes · 2020-10-05T17:13:02Z

@elasticmachine merge upstream

kibanamachine · 2020-10-05T18:45:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 92e3c12

Metrics [docs]

@kbn/optimizer bundle module count

id	before	after	diff
`apm`	1276	1275	-1

distributable file count

id	before	after	diff
`default`	47112	47116	+4

page load bundle size

id	before	after	diff
`apm`	44.3KB	46.2KB	+2.0KB

History

💚 Build #79696 succeeded d5bbb00
💚 Build #79560 succeeded e62cae2
💚 Build #79543 succeeded 5d0e902
💛 Build #79487 was flaky b5720ec
💚 Build #79176 succeeded 87bb823

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* adding default message * addressing pr comments * addressing pr comments * addressing pr comments * addressing pr comments Co-authored-by: Kibana Machine <[email protected]>

* master: (85 commits) Refactor attribute service (elastic#78414) [APM] Add default message to alerts. (elastic#78930) [Discover] Modify columns and sort when switching index pattern (elastic#74336) Document ts project references setup (elastic#78586) build all ts refs in single kbn:bootstrap (elastic#79438) [TSVB] Allow string fields on value count aggregation (elastic#79267) [SECURITY SOLUTION] Investigate EQL signal in timeline (elastic#79049) [Fleet] Add loading spinner to page headers (elastic#79568) [Security Solution][Resolver] Resolver query panel load more (elastic#79160) Add type row to monitor detail page. (elastic#79556) Remove license refresh from setup (elastic#79518) [docker] add reporting fonts (elastic#74806) [SECURITY_SOLUTION][ENDPOINT] Add info about trusted apps to the page subtitle + create flyout (elastic#79558) Trim Hash value before validating it (elastic#79545) Warn users when security is not configured (elastic#78545) update copy styling (elastic#79313) Update dependency @elastic/charts to v23.1.1 (elastic#78459) Introduce geo-threshold alerts (elastic#76285) elastic#76920 Show base breadcrumb when there is an error booting the app (elastic#79571) remove react-intl from kibana and keep it inside only i18n package (elastic#78956) ...

* adding default message * addressing pr comments * addressing pr comments * addressing pr comments * addressing pr comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

sorenlouv · 2020-10-12T12:08:05Z

✅ This was tested with the kibana_write_user. Default messages showed up for email and slack (not the other actions).

adding default message

f9bd3c4

cauemarcondes added release_note:enhancement v7.10.0 apm:alerting labels Sep 30, 2020

cauemarcondes requested a review from a team as a code owner September 30, 2020 11:12

botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 30, 2020

cauemarcondes requested review from formgeist and bmorelli25 September 30, 2020 11:12

sorenlouv reviewed Sep 30, 2020

View reviewed changes

x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts Outdated Show resolved Hide resolved

sorenlouv reviewed Sep 30, 2020

View reviewed changes

x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts Outdated Show resolved Hide resolved

sorenlouv reviewed Sep 30, 2020

View reviewed changes

x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts Outdated Show resolved Hide resolved

sorenlouv reviewed Sep 30, 2020

View reviewed changes

x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts Outdated Show resolved Hide resolved

formgeist approved these changes Oct 1, 2020

View reviewed changes

bmorelli25 approved these changes Oct 1, 2020

View reviewed changes

cauemarcondes added 2 commits October 2, 2020 16:39

addressing pr comments

33cfd9e

Merge branch 'master' of github.com:elastic/kibana into apm-alerts-de…

87bb823

…fault-message

cauemarcondes requested a review from sorenlouv October 5, 2020 07:59

Merge branch 'master' into apm-alerts-default-message

b5720ec

sorenlouv reviewed Oct 5, 2020

View reviewed changes

x-pack/plugins/apm/server/lib/alerts/action_variables.ts Outdated Show resolved Hide resolved

sorenlouv reviewed Oct 5, 2020

View reviewed changes

x-pack/plugins/apm/server/lib/alerts/register_transaction_error_rate_alert_type.ts Outdated Show resolved Hide resolved

cauemarcondes added 2 commits October 5, 2020 13:14

addressing pr comments

5d0e902

addressing pr comments

e62cae2

sorenlouv reviewed Oct 5, 2020

View reviewed changes

x-pack/plugins/apm/common/utils/formatters/formatters.test.ts Outdated Show resolved Hide resolved

addressing pr comments

d5bbb00

cauemarcondes requested a review from sorenlouv October 5, 2020 17:12

Merge branch 'master' into apm-alerts-default-message

92e3c12

sorenlouv approved these changes Oct 5, 2020

View reviewed changes

cauemarcondes merged commit ffc1caa into elastic:master Oct 6, 2020

cauemarcondes deleted the apm-alerts-default-message branch October 6, 2020 07:18

cauemarcondes mentioned this pull request Oct 6, 2020

[7.x] [APM] Add default message to alerts. (#78930) #79620

Merged

dB2510 mentioned this pull request Oct 7, 2020

add defaultActionMessage to index threshold alert UI type definition #78148

Closed

sorenlouv added the apm:test-plan-7.10.0 label Oct 7, 2020

sorenlouv self-assigned this Oct 12, 2020

sorenlouv added the apm:test-plan-done Pull request that was successfully tested during the test plan label Oct 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Add default message to alerts. #78930

[APM] Add default message to alerts. #78930

cauemarcondes commented Sep 30, 2020

elasticmachine commented Sep 30, 2020

cauemarcondes commented Sep 30, 2020

sorenlouv commented Sep 30, 2020

formgeist left a comment

sorenlouv commented Oct 1, 2020 •

edited

Loading

bmorelli25 left a comment

formgeist commented Oct 1, 2020

bmorelli25 commented Oct 1, 2020

cauemarcondes commented Oct 5, 2020

sorenlouv Oct 5, 2020 •

edited

Loading

cauemarcondes commented Oct 5, 2020

kibanamachine commented Oct 5, 2020

sorenlouv commented Oct 12, 2020

	'The interval size the alert will use to check for any incident',
	'The length of the time period where the alert conditions were met',

	'The interval size the alert will use to check for any incident',
	'The alert will trigger if the conditions are met within the given interval',

[APM] Add default message to alerts. #78930

[APM] Add default message to alerts. #78930

Conversation

cauemarcondes commented Sep 30, 2020

elasticmachine commented Sep 30, 2020

cauemarcondes commented Sep 30, 2020

sorenlouv commented Sep 30, 2020

formgeist left a comment

Choose a reason for hiding this comment

sorenlouv commented Oct 1, 2020 • edited Loading

bmorelli25 left a comment

Choose a reason for hiding this comment

formgeist commented Oct 1, 2020

bmorelli25 commented Oct 1, 2020

cauemarcondes commented Oct 5, 2020

sorenlouv Oct 5, 2020 • edited Loading

Choose a reason for hiding this comment

cauemarcondes commented Oct 5, 2020

kibanamachine commented Oct 5, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

distributable file count

page load bundle size

History

sorenlouv commented Oct 12, 2020

sorenlouv commented Oct 1, 2020 •

edited

Loading

sorenlouv Oct 5, 2020 •

edited

Loading