Refactor attribute service #78414
Merged
Refactor attribute service #78414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majagrubic
force-pushed
the
extract-attribute-service
branch
from
e925c51 to
384653f
Compare
added 7 commits
September 28, 2020 13:17
majagrubic
changed the title
ThomThomson
approved these changes
Oct 1, 2020
|
@ThomThomson thanks for the review, I did indeed leave the flag option on while in draft mode, to make reviewing easier. Changed that now. |
|
@elasticmachine merge upstream |
majagrubic
added
release_note:skip
💚 Build SucceededMetrics [docs]page load bundle size
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 6, 2020
* master: (85 commits) Refactor attribute service (elastic#78414) [APM] Add default message to alerts. (elastic#78930) [Discover] Modify columns and sort when switching index pattern (elastic#74336) Document ts project references setup (elastic#78586) build all ts refs in single kbn:bootstrap (elastic#79438) [TSVB] Allow string fields on value count aggregation (elastic#79267) [SECURITY SOLUTION] Investigate EQL signal in timeline (elastic#79049) [Fleet] Add loading spinner to page headers (elastic#79568) [Security Solution][Resolver] Resolver query panel load more (elastic#79160) Add type row to monitor detail page. (elastic#79556) Remove license refresh from setup (elastic#79518) [docker] add reporting fonts (elastic#74806) [SECURITY_SOLUTION][ENDPOINT] Add info about trusted apps to the page subtitle + create flyout (elastic#79558) Trim Hash value before validating it (elastic#79545) Warn users when security is not configured (elastic#78545) update copy styling (elastic#79313) Update dependency @elastic/charts to v23.1.1 (elastic#78459) Introduce geo-threshold alerts (elastic#76285) elastic#76920 Show base breadcrumb when there is an error booting the app (elastic#79571) remove react-intl from kibana and keep it inside only i18n package (elastic#78956) ...
majagrubic
pushed a commit
that referenced
this pull request
Oct 6, 2020
* Making saveMethod mandatory in attribute service * Making unwrap method mandatory * Making book embeddable respect new attribute service * Remove savedObjectsClient from attribute service * Add checkForDuplicateTitle method to book embeddable * Make options mandatory on attribute service * Changing Lens attribute service * Somw more typescript fixes * Fixing attribute service typescript and tests * Fixing typescript errors * Unsetting feature flag Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
First iteration of addressing: #77505
What this PR does:
savedObjectsClientdependency fromAttributeServicesavedObjectsClientmandatory for attribute service - ie.saveMethod,unwrapMethod,checkForDuplicateTitleWhat this PR doesn't do:
Would love to get early feedback on this and if this is how you think it should work.
Checklist
Delete any items that are not applicable to this PR.
For maintainers