Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Add default message to alerts. #78573

Closed
cauemarcondes opened this issue Sep 28, 2020 · 8 comments · Fixed by #78930
Closed

[APM] Add default message to alerts. #78573

cauemarcondes opened this issue Sep 28, 2020 · 8 comments · Fixed by #78930
Assignees
Labels
apm:alerting enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v7.10.0

Comments

@cauemarcondes
Copy link
Contributor

cauemarcondes commented Sep 28, 2020

The alerts API defines a prop called defaultActionMessage to set a default message for the user.

  • Add defaultActionMessage to the alerts available.

@formgeist @bmorelli25 I could use some help to define a message for each alert we have:

  • Transaction duration threshold
  • Transaction duration anomaly
  • Transaction error rate
  • Error count

Example placeholder message templates from other alert types

Uptime anomaly alert

Abnormal ({{state.severity}} level) response time detected on {{state.monitor}} with url {{{state.monitorUrl}}} at {{state.anomalyStartTimestamp}}. Anomaly severity score is {{state.severityScore}}.
Response times as high as {{state.slowestAnomalyResponse}} have been detected from location {{state.observerLocation}}. Expected response time is {{state.expectedResponseTime}}.

Inventory threshold alert

{{alertName}} - {{context.group}} is in a state of {{context.alertState}}

Reason:
{{context.reason}}
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist
Copy link
Contributor

@cauemarcondes Just to clarify - are we able to bucket the services together into a single alert? I assume this is something we should keep in mind when creating the placeholder copy.

@sorenlouv
Copy link
Member

sorenlouv commented Sep 29, 2020

@cauemarcondes Can you make a draft PR with these changes, and the initial copy for the default messages? That'll make it easier for @formgeist / @bmorelli25 to see what's possible.

@cauemarcondes
Copy link
Contributor Author

@formgeist no, for 7.10 we're sending unique alerts per service/environment/transaction_type.

@cauemarcondes
Copy link
Contributor Author

@cauemarcondes Can you make a draft PR with these changes, and the initial copy for the default messages? That'll make it easier for @formgeist / @bmorelli25 to see what's possible.

Yes, working on that @sqren 😁

@cauemarcondes
Copy link
Contributor Author

And is good to keep in mind that the default message is not supported by all actions.

@sorenlouv
Copy link
Member

And is good to keep in mind that the default message is not supported by all actions.

I think @pmuellr is working on that :)

@formgeist
Copy link
Contributor

I've added some placeholder examples to the description. They're not really in the same "language", but I want to strive for that in ours at least. Then we can make them more consistent with the other Observability apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:alerting enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v7.10.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants